[Aptos Framework] Validate against empty execution hash in voting::resolve() #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movekevin
requested review from
wrwg,
areshand,
0xchloe,
davidiw,
junkil-park and
vgao1996
junkil-park
approved these changes
Jul 22, 2022
❌ Forge test failureForge is land-blocking |
✅ Forge test successForge is land-blocking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Empty execution hash technically is not exploitable as transaction_context::script_hash() only returns empty if voting::resolve() is called from a script function and not script. This is not a serious issue as the transaction can only call voting::resolve() but cannot do anything else (script function is a single call per transaction). However, we might as well add a validation against empty execution hash for peace of mind.
Test Plan
Unit Tests
This change is