Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][AA] fix visibility issues #15876

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

lightmark
Copy link
Contributor

cherry pick #15858

Copy link

trunk-io bot commented Feb 3, 2025

⏱️ 1h 28m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-unit-tests 27m 🟩
rust-unit-tests 24m 🟩
execution-performance / single-node-performance 6m 🟥
test-target-determinator 6m 🟩
execution-performance / test-target-determinator 6m 🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 5m 🟩🟩
rust-cargo-deny 4m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
semgrep/ci 58s 🟩🟩
general-lints 55s 🟩🟩
file_change_determinator 25s 🟩🟩
file_change_determinator 11s 🟩
permission-check 5s 🟩🟩
permission-check 4s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
test-target-determinator 6m 5m +23%

settingsfeedbackdocs ⋅ learn more about trunk.io

@lightmark lightmark requested a review from gregnazario February 3, 2025 21:29
@lightmark
Copy link
Contributor Author

manually cherry pick to save time

@igor-aptos igor-aptos enabled auto-merge (squash) February 4, 2025 00:45

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

✅ Forge suite realistic_env_max_load success on 63e72509943011847db7c11b4b26bcdc503fb5fc

two traffics test: inner traffic : committed: 13491.24 txn/s, submitted: 13507.96 txn/s, expired: 16.73 txn/s, latency: 2866.11 ms, (p50: 2700 ms, p70: 2900, p90: 3300 ms, p99: 5000 ms), latency samples: 5129720
two traffics test : committed: 100.00 txn/s, latency: 1829.71 ms, (p50: 1700 ms, p70: 2000, p90: 2600 ms, p99: 4100 ms), latency samples: 2000
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.403, avg: 1.164", "ConsensusProposalToOrdered: max: 0.306, avg: 0.302", "ConsensusOrderedToCommit: max: 0.601, avg: 0.542", "ConsensusProposalToCommit: max: 0.902, avg: 0.844"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.51s no progress at version 5834954 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.70s no progress at version 5833582 (avg 0.70s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Feb 4, 2025

✅ Forge suite compat success on 8d5d045ede6dae476482b2b9c3a80893c521eaa5 ==> 63e72509943011847db7c11b4b26bcdc503fb5fc

Compatibility test results for 8d5d045ede6dae476482b2b9c3a80893c521eaa5 ==> 63e72509943011847db7c11b4b26bcdc503fb5fc (PR)
1. Check liveness of validators at old version: 8d5d045ede6dae476482b2b9c3a80893c521eaa5
compatibility::simple-validator-upgrade::liveness-check : committed: 16858.67 txn/s, latency: 2064.89 ms, (p50: 1900 ms, p70: 2100, p90: 3000 ms, p99: 5100 ms), latency samples: 542000
2. Upgrading first Validator to new version: 63e72509943011847db7c11b4b26bcdc503fb5fc
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3722.40 txn/s, latency: 8147.81 ms, (p50: 8800 ms, p70: 9800, p90: 10400 ms, p99: 10500 ms), latency samples: 82440
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3737.66 txn/s, latency: 9199.05 ms, (p50: 10100 ms, p70: 10300, p90: 10600 ms, p99: 10700 ms), latency samples: 134120
3. Upgrading rest of first batch to new version: 63e72509943011847db7c11b4b26bcdc503fb5fc
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3222.60 txn/s, latency: 9126.50 ms, (p50: 9900 ms, p70: 11200, p90: 11900 ms, p99: 12100 ms), latency samples: 71040
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3243.74 txn/s, latency: 10625.45 ms, (p50: 11700 ms, p70: 11900, p90: 12200 ms, p99: 12300 ms), latency samples: 126200
4. upgrading second batch to new version: 63e72509943011847db7c11b4b26bcdc503fb5fc
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 6898.01 txn/s, latency: 4428.09 ms, (p50: 5100 ms, p70: 5300, p90: 5800 ms, p99: 5900 ms), latency samples: 128300
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3634.73 txn/s, submitted: 3634.91 txn/s, expired: 0.18 txn/s, latency: 5126.80 ms, (p50: 5400 ms, p70: 5800, p90: 5900 ms, p99: 6000 ms), latency samples: 227729
5. check swarm health
Compatibility test for 8d5d045ede6dae476482b2b9c3a80893c521eaa5 ==> 63e72509943011847db7c11b4b26bcdc503fb5fc passed
Test Ok

@igor-aptos igor-aptos merged commit 6760e82 into aptos-release-v1.26 Feb 4, 2025
89 of 90 checks passed
@igor-aptos igor-aptos deleted the lightmark/aa_fix_cp_1.26 branch February 4, 2025 01:13
Copy link

trunk-io bot commented Feb 4, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants