Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qs: undo using block votes to fetch batches #15786

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ibalajiarun
Copy link
Contributor

Description

Basically, get_transactions is not cancellation safe, so it cannot be polled in a select statement.

Copy link

trunk-io bot commented Jan 22, 2025

⏱️ 35m total CI duration on this PR
Job Cumulative Duration Recent Runs
check-dynamic-deps 13m 🟩🟩🟩🟩🟩
test-target-determinator 10m 🟩🟩
rust-cargo-deny 7m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
general-lints 2m 🟩🟩🟩🟩
file_change_determinator 53s 🟩🟩🟩🟩🟩
file_change_determinator 38s 🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩🟩
permission-check 7s 🟩🟩🟩
determine-docker-build-metadata 6s 🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@ibalajiarun ibalajiarun added the CICD:run-forge-e2e-perf Run the e2e perf forge only label Jan 22, 2025

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 9521a0675da63cf727072b0e91dac79d3fbb4d80

two traffics test: inner traffic : committed: 14537.67 txn/s, submitted: 14544.61 txn/s, expired: 6.94 txn/s, latency: 2700.07 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5527540
two traffics test : committed: 99.96 txn/s, latency: 1504.77 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 4200 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.527, avg: 1.477", "ConsensusProposalToOrdered: max: 0.297, avg: 0.290", "ConsensusOrderedToCommit: max: 0.429, avg: 0.402", "ConsensusProposalToCommit: max: 0.727, avg: 0.692"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.76s no progress at version 3328726 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.62s no progress at version 2391941 (avg 0.62s) [limit 16].
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-forge-e2e-perf Run the e2e perf forge only v1.26
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants