Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bytecode version for upgrade test #15758

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

rahxephon89
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 16, 2025

⏱️ 1h 3m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
test-target-determinator 16m 🟩🟩🟩
check-dynamic-deps 10m 🟩🟩🟩🟩
execution-performance / test-target-determinator 9m 🟩🟩
rust-cargo-deny 6m 🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 5m 🟩🟩🟩
general-lints 2m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 44s 🟩🟩🟩🟩
file_change_determinator 31s 🟩🟩🟩
execution-performance / single-node-performance 21s 🟩🟩
permission-check 13s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 8s 🟩🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 2m +71%
test-target-determinator 6m 5m +23%

settingsfeedbackdocs ⋅ learn more about trunk.io

@rahxephon89 rahxephon89 marked this pull request as ready for review January 16, 2025 19:55
@rahxephon89 rahxephon89 changed the title [WIP] fix bytecode version for upgrade test fix bytecode version for upgrade test Jan 16, 2025

This comment has been minimized.

@rahxephon89 rahxephon89 enabled auto-merge (squash) January 16, 2025 20:00

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 0248b9d74fd200afcc9343284ac740b9eb136d8e

Compatibility test results for f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 0248b9d74fd200afcc9343284ac740b9eb136d8e (PR)
1. Check liveness of validators at old version: f69dc31b0f674662b6bfa941dc7eee9ce9035e29
compatibility::simple-validator-upgrade::liveness-check : committed: 14747.82 txn/s, latency: 2177.71 ms, (p50: 2200 ms, p70: 2400, p90: 2700 ms, p99: 3500 ms), latency samples: 487300
2. Upgrading first Validator to new version: 0248b9d74fd200afcc9343284ac740b9eb136d8e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4127.81 txn/s, latency: 7487.88 ms, (p50: 8300 ms, p70: 8900, p90: 9200 ms, p99: 9300 ms), latency samples: 90760
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4038.35 txn/s, latency: 8403.19 ms, (p50: 9100 ms, p70: 9200, p90: 9700 ms, p99: 10100 ms), latency samples: 142580
3. Upgrading rest of first batch to new version: 0248b9d74fd200afcc9343284ac740b9eb136d8e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4935.55 txn/s, latency: 6260.11 ms, (p50: 7000 ms, p70: 7500, p90: 7900 ms, p99: 7900 ms), latency samples: 98420
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4820.73 txn/s, latency: 7145.18 ms, (p50: 7900 ms, p70: 8000, p90: 8200 ms, p99: 8200 ms), latency samples: 172620
4. upgrading second batch to new version: 0248b9d74fd200afcc9343284ac740b9eb136d8e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7993.98 txn/s, latency: 3839.45 ms, (p50: 4400 ms, p70: 4600, p90: 4800 ms, p99: 5000 ms), latency samples: 151000
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7963.35 txn/s, latency: 4281.60 ms, (p50: 4600 ms, p70: 4800, p90: 4900 ms, p99: 5100 ms), latency samples: 267540
5. check swarm health
Compatibility test for f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 0248b9d74fd200afcc9343284ac740b9eb136d8e passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 0248b9d74fd200afcc9343284ac740b9eb136d8e

two traffics test: inner traffic : committed: 14786.79 txn/s, latency: 2685.59 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5622360
two traffics test : committed: 99.96 txn/s, latency: 1409.99 ms, (p50: 1300 ms, p70: 1400, p90: 1800 ms, p99: 2700 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.555, avg: 1.425", "ConsensusProposalToOrdered: max: 0.297, avg: 0.290", "ConsensusOrderedToCommit: max: 0.325, avg: 0.314", "ConsensusProposalToCommit: max: 0.613, avg: 0.604"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.53s no progress at version 30800 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.54s no progress at version 2525638 (avg 0.54s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 0248b9d74fd200afcc9343284ac740b9eb136d8e

Compatibility test results for f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 0248b9d74fd200afcc9343284ac740b9eb136d8e (PR)
Upgrade the nodes to version: 0248b9d74fd200afcc9343284ac740b9eb136d8e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 622.09 txn/s, submitted: 624.22 txn/s, failed submission: 1.94 txn/s, expired: 2.13 txn/s, latency: 8763.46 ms, (p50: 2100 ms, p70: 3100, p90: 33500 ms, p99: 35200 ms), latency samples: 44966
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 978.89 txn/s, submitted: 981.41 txn/s, failed submission: 2.05 txn/s, expired: 2.52 txn/s, latency: 6167.32 ms, (p50: 2100 ms, p70: 2600, p90: 35900 ms, p99: 40600 ms), latency samples: 76285
5. check swarm health
Compatibility test for f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 0248b9d74fd200afcc9343284ac740b9eb136d8e passed
Upgrade the remaining nodes to version: 0248b9d74fd200afcc9343284ac740b9eb136d8e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 576.33 txn/s, submitted: 581.71 txn/s, failed submission: 0.28 txn/s, expired: 5.38 txn/s, latency: 13378.06 ms, (p50: 1800 ms, p70: 2700, p90: 53700 ms, p99: 59300 ms), latency samples: 40462
Test Ok

@rahxephon89 rahxephon89 merged commit 6716334 into main Jan 16, 2025
46 checks passed
@rahxephon89 rahxephon89 deleted the teng/fix-bytecode-version branch January 16, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants