Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recalibrate perf benchmarks for current stable values #15685

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

igor-aptos
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 7, 2025

Copy link
Contributor

@msmouse msmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you boss

@igor-aptos igor-aptos added CICD:run-execution-performance-test Run execution performance test CICD:run-execution-performance-full-test Run execution performance test (full version) and removed CICD:run-execution-performance-test Run execution performance test CICD:run-execution-performance-full-test Run execution performance test (full version) labels Jan 7, 2025
@igor-aptos igor-aptos enabled auto-merge (squash) January 7, 2025 22:53

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

✅ Forge suite realistic_env_max_load success on 4cdbf8654ca470cd71e6ea9da218dd9286297c27

two traffics test: inner traffic : committed: 14868.30 txn/s, latency: 2673.32 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3200 ms), latency samples: 5653260
two traffics test : committed: 99.97 txn/s, latency: 1342.11 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 1600 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.570, avg: 1.527", "ConsensusProposalToOrdered: max: 0.289, avg: 0.287", "ConsensusOrderedToCommit: max: 0.308, avg: 0.298", "ConsensusProposalToCommit: max: 0.596, avg: 0.585"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.89s no progress at version 32231 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.56s no progress at version 2751234 (avg 0.56s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Jan 7, 2025

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> 4cdbf8654ca470cd71e6ea9da218dd9286297c27

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> 4cdbf8654ca470cd71e6ea9da218dd9286297c27 (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 17086.03 txn/s, latency: 2050.90 ms, (p50: 2100 ms, p70: 2100, p90: 2300 ms, p99: 3900 ms), latency samples: 549440
2. Upgrading first Validator to new version: 4cdbf8654ca470cd71e6ea9da218dd9286297c27
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7983.13 txn/s, latency: 3771.54 ms, (p50: 4400 ms, p70: 4500, p90: 4700 ms, p99: 4700 ms), latency samples: 149460
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7907.89 txn/s, latency: 4245.30 ms, (p50: 4600 ms, p70: 4700, p90: 4900 ms, p99: 5300 ms), latency samples: 259700
3. Upgrading rest of first batch to new version: 4cdbf8654ca470cd71e6ea9da218dd9286297c27
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7566.33 txn/s, latency: 3951.25 ms, (p50: 4600 ms, p70: 4800, p90: 4900 ms, p99: 5000 ms), latency samples: 142180
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7318.92 txn/s, latency: 4603.70 ms, (p50: 5000 ms, p70: 5100, p90: 5300 ms, p99: 5600 ms), latency samples: 246060
4. upgrading second batch to new version: 4cdbf8654ca470cd71e6ea9da218dd9286297c27
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12285.40 txn/s, latency: 2393.32 ms, (p50: 2700 ms, p70: 2800, p90: 3000 ms, p99: 3200 ms), latency samples: 213120
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12272.39 txn/s, latency: 2681.49 ms, (p50: 2800 ms, p70: 2900, p90: 3000 ms, p99: 3100 ms), latency samples: 396000
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> 4cdbf8654ca470cd71e6ea9da218dd9286297c27 passed
Test Ok

@igor-aptos igor-aptos merged commit 8ff3aa1 into main Jan 7, 2025
151 of 152 checks passed
@igor-aptos igor-aptos deleted the igor/recalibrate_jan_7 branch January 7, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants