Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the doc on internal indexer config #15677

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Update the doc on internal indexer config #15677

merged 1 commit into from
Jan 10, 2025
+26 −0

Conversation

areshand
Copy link
Contributor

@areshand areshand commented Jan 6, 2025

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Jan 6, 2025 •
edited
Loading

⏱️ 1h 7m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 13m 🟩 
rust-move-tests 13m 🟩 
rust-move-tests 13m 🟩 
rust-doc-tests 5m 🟩 
test-target-determinator 5m 🟩 
execution-performance / test-target-determinator 5m 🟩 
check-dynamic-deps 4m 🟩 🟩 🟩 🟩 
rust-cargo-deny 2m 🟥 🟥 🟥 🟩 
semgrep/ci 2m 🟩 🟩 🟩 🟩 
fetch-last-released-docker-image-tag 1m 🟩 
file_change_determinator 46s 🟩 🟩 🟩 🟩 
general-lints 39s 🟩 🟩 🟩 🟩 
rust-move-tests 14s ⬜ 
file_change_determinator 11s 🟩 
permission-check 11s 🟩 🟩 🟩 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

graphite-app[bot]
graphite-app bot reviewed Jan 6, 2025
View reviewed changes
storage/README.md Outdated Show resolved Hide resolved
@areshand areshand requested a review from grao1991 January 6, 2025 22:08
graphite-app[bot]
graphite-app bot reviewed Jan 6, 2025
View reviewed changes
storage/README.md
Comment on lines +168 to +169
The internal indexer is configured as below.
The batch size is used to chunk the transactions to smaller batches before writting to internal indexer DB.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor typos in this section:

  • configed -> configured
  • writting -> writing

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

graphite-app[bot]
graphite-app bot reviewed Jan 6, 2025
View reviewed changes
storage/README.md
* /accounts/{address}/resources

The internal indexer is configured as below.
The batch size is used to chunk the transactions to smaller batches before writting to internal indexer DB.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo: writting -> writing

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@areshand
Copy link
Contributor Author

@msmouse stamp this ?

@areshand areshand enabled auto-merge (rebase) January 10, 2025 18:53
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 8ed82c5c3997225d6eaecb38c4a7866085811224

two traffics test: inner traffic : committed: 14852.11 txn/s, latency: 2676.12 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3200 ms), latency samples: 5647060
two traffics test : committed: 99.97 txn/s, latency: 1341.02 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 1600 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.576, avg: 1.528", "ConsensusProposalToOrdered: max: 0.291, avg: 0.287", "ConsensusOrderedToCommit: max: 0.311, avg: 0.304", "ConsensusProposalToCommit: max: 0.599, avg: 0.591"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.53s no progress at version 567 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.58s no progress at version 2269039 (avg 0.58s) [limit 16].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> 8ed82c5c3997225d6eaecb38c4a7866085811224

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> 8ed82c5c3997225d6eaecb38c4a7866085811224 (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 17581.06 txn/s, latency: 1964.68 ms, (p50: 2000 ms, p70: 2100, p90: 2400 ms, p99: 3000 ms), latency samples: 583700
2. Upgrading first Validator to new version: 8ed82c5c3997225d6eaecb38c4a7866085811224
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6436.51 txn/s, latency: 4557.04 ms, (p50: 5200 ms, p70: 5500, p90: 5700 ms, p99: 5800 ms), latency samples: 124220
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6638.84 txn/s, latency: 5132.41 ms, (p50: 5600 ms, p70: 5700, p90: 5900 ms, p99: 6100 ms), latency samples: 227220
3. Upgrading rest of first batch to new version: 8ed82c5c3997225d6eaecb38c4a7866085811224
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6404.23 txn/s, latency: 4656.66 ms, (p50: 5400 ms, p70: 5700, p90: 5800 ms, p99: 5900 ms), latency samples: 119340
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6425.27 txn/s, latency: 5292.82 ms, (p50: 5800 ms, p70: 5900, p90: 6100 ms, p99: 6200 ms), latency samples: 222680
4. upgrading second batch to new version: 8ed82c5c3997225d6eaecb38c4a7866085811224
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12608.77 txn/s, latency: 2311.18 ms, (p50: 2600 ms, p70: 2700, p90: 2900 ms, p99: 3100 ms), latency samples: 219240
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12717.18 txn/s, latency: 2557.10 ms, (p50: 2700 ms, p70: 2800, p90: 2900 ms, p99: 3100 ms), latency samples: 412060
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> 8ed82c5c3997225d6eaecb38c4a7866085811224 passed
Test Ok

@areshand areshand merged commit 4b1b3e9 into main Jan 10, 2025
87 of 88 checks passed
@areshand areshand deleted the update_doc branch January 10, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@grao1991 grao1991 grao1991 approved these changes

@msmouse msmouse msmouse approved these changes

@lightmark lightmark Awaiting requested review from lightmark lightmark is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@areshand @msmouse @grao1991