[move-vm][closures] Types and opcodes for closures #15667
+800
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 13m total CI duration on this PR
|
wrwg
force-pushed
the
wrwg/clos_file_format
branch
4 times, most recently
from
9688bde to
f2effc9
Compare
wrwg
requested review from
vgao1996
and removed request for
gregnazario,
banool and
0xmaayan
wrwg
force-pushed
the
wrwg/clos_file_format
branch
3 times, most recently
from
0aa8d5d to
301ccae
Compare
wrwg
force-pushed
the
wrwg/clos_file_format
branch
3 times, most recently
from
0ebce3a to
58fbf2b
Compare
wrwg
force-pushed
the
wrwg/clos_file_format
branch
2 times, most recently
from
d9a4a9f to
e2b0141
Compare
This was referenced Jan 21, 2025
wrwg
force-pushed
the
wrwg/clos_file_format
branch
from
e2b0141 to
53b97a8
Compare
|
@wrwg I think this PR got V8 binary format change leaked into it |
wrwg
force-pushed
the
wrwg/clos_file_format
branch
from
53b97a8 to
58fb6ba
Compare
wrwg
force-pushed
the
wrwg/clos_file_format
branch
from
58fb6ba to
55a5551
Compare
Can't see any unexpected. This PR is based on the (now landed) v8 PR. Perhaps there was a merge conflict which is now resolved after rebase? |
wrwg
force-pushed
the
wrwg/clos_file_format
branch
from
55a5551 to
ffc2f2d
Compare
This PR implements the extensions needed in the file format for representing closures: - The type (SignatureToken) has a new variant `Function(args, result, abilities)` to represent a function type - The opcodes are extendeed by operations `ClosPack`, `ClosPackGeneric`, and `ClosEval` This supports bit masks for specifyinng which arguments of a function are captured when creating a closure. Bytecode verification is extended to support the new types and opcodes. The implementation of consistency, type, and reference safety should be complete. What is missing are: - File format serialization - Interpreter and value representation - Value serialization - Connection of the new types with the various other type representations
wrwg
force-pushed
the
wrwg/clos_file_format
branch
from
ffc2f2d to
781423d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[PR 1/n for vm closures]
This PR implements the extensions needed in the file format for representing closures:
SignatureTokenhas a new variantFunction(args, result, abilities)to represent a function typePackClosure,PackClosureGeneric, andCallClosureThis supports bit masks for specifying which arguments of a function are captured when creating a closure.
Bytecode verification is extended to support the new types and opcodes. The implementation of consistency, type, and reference safety should be complete. What is missing are:
How Has This Been Tested?
Testing postponed until e2e wiring is ready
Type of Change
Which Components or Systems Does This Change Impact?