Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[block-executor] Remove unused executable type #15601

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

georgemitenkov
Copy link
Contributor

@georgemitenkov georgemitenkov commented Dec 14, 2024

Description

X: Executable is not used on block executor:

  • It was not integrated into V1 loader.
  • V2 loader ended up using a separate path for execution and concrete types (for now).
    Removing the type parameter from the executor, as wall as the old cross-block module cache implementation (we have a cache manager now). Old modules MVHashMap is still kept generic though.

How Has This Been Tested?

N/A

Key Areas to Review

N/A

Type of Change

  • Refactoring

Which Components or Systems Does This Change Impact?

  • Move/Aptos Virtual Machine

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 14, 2024

⏱️ 16m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-cargo-deny 2m 🟩
check-dynamic-deps 40s 🟩
general-lints 29s 🟩
semgrep/ci 27s 🟩
file_change_determinator 15s 🟩
permission-check 2s 🟩
permission-check 2s 🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

// The cache is updated / synchronized after a piece is executed.
Updated(Option<ID>),
// The cache is pruned to control memory usage.
Pruned(Option<ID>),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only thing we don't yet have in the manager, but will do when we need I guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updates are now done at boundaries, and pruning as well. Once we need this at finer regularity, we can add these states there.

@georgemitenkov georgemitenkov force-pushed the george/remove-executable-type branch from e6123ac to bce53ac Compare January 6, 2025 10:00
@georgemitenkov georgemitenkov force-pushed the george/remove-executable-type branch from bce53ac to 0a5f1fd Compare January 8, 2025 20:31
@georgemitenkov georgemitenkov enabled auto-merge (squash) January 8, 2025 20:32

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> 0a5f1fd4e3fdba26b7b6d956526fc700bb969636

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> 0a5f1fd4e3fdba26b7b6d956526fc700bb969636 (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 17562.84 txn/s, latency: 1983.37 ms, (p50: 1800 ms, p70: 2100, p90: 2700 ms, p99: 4200 ms), latency samples: 572040
2. Upgrading first Validator to new version: 0a5f1fd4e3fdba26b7b6d956526fc700bb969636
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 8398.48 txn/s, latency: 3638.57 ms, (p50: 3600 ms, p70: 4100, p90: 4400 ms, p99: 4500 ms), latency samples: 150860
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 8223.76 txn/s, latency: 4044.40 ms, (p50: 4400 ms, p70: 4500, p90: 4500 ms, p99: 4500 ms), latency samples: 276420
3. Upgrading rest of first batch to new version: 0a5f1fd4e3fdba26b7b6d956526fc700bb969636
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 8121.37 txn/s, latency: 3697.74 ms, (p50: 4300 ms, p70: 4400, p90: 4500 ms, p99: 4600 ms), latency samples: 151020
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 8023.87 txn/s, latency: 4199.80 ms, (p50: 4500 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 269820
4. upgrading second batch to new version: 0a5f1fd4e3fdba26b7b6d956526fc700bb969636
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7206.32 txn/s, latency: 4251.58 ms, (p50: 2500 ms, p70: 7000, p90: 8400 ms, p99: 9000 ms), latency samples: 124040
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12764.71 txn/s, latency: 2539.08 ms, (p50: 2700 ms, p70: 2800, p90: 2900 ms, p99: 3200 ms), latency samples: 413680
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> 0a5f1fd4e3fdba26b7b6d956526fc700bb969636 passed
Test Ok

Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ Forge suite realistic_env_max_load success on 0a5f1fd4e3fdba26b7b6d956526fc700bb969636

two traffics test: inner traffic : committed: 14633.66 txn/s, latency: 2717.20 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 4500 ms), latency samples: 5564100
two traffics test : committed: 99.97 txn/s, latency: 1348.89 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 2400 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.637, avg: 1.539", "ConsensusProposalToOrdered: max: 0.294, avg: 0.288", "ConsensusOrderedToCommit: max: 0.315, avg: 0.303", "ConsensusProposalToCommit: max: 0.610, avg: 0.592"]
Max non-epoch-change gap was: 1 rounds at version 5826163 (avg 0.00) [limit 4], 2.61s no progress at version 5826163 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.57s no progress at version 2709096 (avg 0.57s) [limit 16].
Test Ok

@georgemitenkov georgemitenkov merged commit ae09c85 into main Jan 8, 2025
83 of 88 checks passed
@georgemitenkov georgemitenkov deleted the george/remove-executable-type branch January 8, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants