-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[block-executor] Remove unused executable type #15601
Conversation
⏱️ 16m total CI duration on this PR
|
b6634f0
to
e6123ac
Compare
// The cache is updated / synchronized after a piece is executed. | ||
Updated(Option<ID>), | ||
// The cache is pruned to control memory usage. | ||
Pruned(Option<ID>), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only thing we don't yet have in the manager, but will do when we need I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, updates are now done at boundaries, and pruning as well. Once we need this at finer regularity, we can add these states there.
e6123ac
to
bce53ac
Compare
bce53ac
to
0a5f1fd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Description
X: Executable
is not used on block executor:Removing the type parameter from the executor, as wall as the old cross-block module cache implementation (we have a cache manager now). Old modules MVHashMap is still kept generic though.
How Has This Been Tested?
N/A
Key Areas to Review
N/A
Type of Change
Which Components or Systems Does This Change Impact?
Checklist