Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Bump to 5.1.0 #15596

Merged
merged 2 commits into from
Dec 15, 2024
Merged

[cli] Bump to 5.1.0 #15596

merged 2 commits into from
Dec 15, 2024

Conversation

vineethk
Copy link
Contributor

@vineethk vineethk commented Dec 13, 2024

Description

Bump CLI to 5.1.0.

We will run the workflow after all the fixes/features are in main (some of those PRs are still waiting for approvals).

Copy link

trunk-io bot commented Dec 13, 2024

⏱️ 1h 25m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
forge-compat-test / forge 10m 🟩
rust-doc-tests 6m 🟩
check-dynamic-deps 6m 🟩🟩🟩🟩
rust-cargo-deny 6m 🟩🟩🟩
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 4m 🟩
check 4m 🟩
fetch-last-released-docker-image-tag 2m 🟩
semgrep/ci 1m 🟩🟩🟩🟩
general-lints 1m 🟩🟩🟩
file_change_determinator 35s 🟩🟩🟩
permission-check 12s 🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 18m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vineethk vineethk requested review from rahxephon89 and wrwg December 13, 2024 16:24
@vineethk vineethk marked this pull request as ready for review December 13, 2024 16:33
@vineethk vineethk requested a review from fEst1ck December 13, 2024 21:54
@vineethk vineethk force-pushed the vk/update-cli-5-1-0 branch from eafc937 to cccf840 Compare December 13, 2024 23:00
@vineethk vineethk enabled auto-merge (squash) December 15, 2024 03:25

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on e2557d0c6598c96b1bd26b4e156fec5c2de2cc27

two traffics test: inner traffic : committed: 14951.15 txn/s, latency: 2658.78 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3200 ms), latency samples: 5684700
two traffics test : committed: 99.95 txn/s, latency: 1357.02 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 2500 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.567, avg: 1.529", "ConsensusProposalToOrdered: max: 0.309, avg: 0.290", "ConsensusOrderedToCommit: max: 0.295, avg: 0.288", "ConsensusProposalToCommit: max: 0.584, avg: 0.578"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.55s no progress at version 6423986 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.55s no progress at version 2238591 (avg 0.55s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> e2557d0c6598c96b1bd26b4e156fec5c2de2cc27

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> e2557d0c6598c96b1bd26b4e156fec5c2de2cc27 (PR)
Upgrade the nodes to version: e2557d0c6598c96b1bd26b4e156fec5c2de2cc27
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1329.91 txn/s, submitted: 1331.70 txn/s, failed submission: 1.80 txn/s, expired: 1.80 txn/s, latency: 2292.23 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4500 ms), latency samples: 118380
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1417.00 txn/s, submitted: 1420.11 txn/s, failed submission: 3.11 txn/s, expired: 3.11 txn/s, latency: 2093.78 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4200 ms), latency samples: 127680
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> e2557d0c6598c96b1bd26b4e156fec5c2de2cc27 passed
Upgrade the remaining nodes to version: e2557d0c6598c96b1bd26b4e156fec5c2de2cc27
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1354.90 txn/s, submitted: 1358.43 txn/s, failed submission: 3.53 txn/s, expired: 3.53 txn/s, latency: 2199.87 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4200 ms), latency samples: 122740
Test Ok

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> e2557d0c6598c96b1bd26b4e156fec5c2de2cc27

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> e2557d0c6598c96b1bd26b4e156fec5c2de2cc27 (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 15955.35 txn/s, latency: 2107.45 ms, (p50: 1900 ms, p70: 2100, p90: 2700 ms, p99: 5700 ms), latency samples: 537900
2. Upgrading first Validator to new version: e2557d0c6598c96b1bd26b4e156fec5c2de2cc27
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7389.33 txn/s, latency: 3878.67 ms, (p50: 4300 ms, p70: 4500, p90: 4700 ms, p99: 5000 ms), latency samples: 138920
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7791.86 txn/s, latency: 4216.89 ms, (p50: 4500 ms, p70: 4600, p90: 4700 ms, p99: 4900 ms), latency samples: 261400
3. Upgrading rest of first batch to new version: e2557d0c6598c96b1bd26b4e156fec5c2de2cc27
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6744.89 txn/s, latency: 4241.87 ms, (p50: 4900 ms, p70: 5100, p90: 5200 ms, p99: 5300 ms), latency samples: 123400
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6897.20 txn/s, latency: 4775.23 ms, (p50: 5100 ms, p70: 5200, p90: 5400 ms, p99: 5600 ms), latency samples: 233880
4. upgrading second batch to new version: e2557d0c6598c96b1bd26b4e156fec5c2de2cc27
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11795.20 txn/s, latency: 2303.65 ms, (p50: 2200 ms, p70: 2700, p90: 3300 ms, p99: 3500 ms), latency samples: 207100
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11323.26 txn/s, latency: 2663.47 ms, (p50: 2300 ms, p70: 3100, p90: 3400 ms, p99: 5500 ms), latency samples: 399540
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> e2557d0c6598c96b1bd26b4e156fec5c2de2cc27 passed
Test Ok

@vineethk vineethk merged commit 7ccbfaf into main Dec 15, 2024
76 of 88 checks passed
@vineethk vineethk deleted the vk/update-cli-5-1-0 branch December 15, 2024 04:16
georgemitenkov pushed a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants