Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Release 4.7.0 #15556

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[cli] Release 4.7.0 #15556

merged 1 commit into from
Dec 10, 2024

Conversation

gregnazario
Copy link
Contributor

Description

CLI Release 4.7.0 to fix issues with ledger

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 10, 2024

⏱️ 44m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 4m 🟩
rust-move-tests 4m
check 4m 🟩
rust-cargo-deny 4m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
check-dynamic-deps 1m 🟩🟩
general-lints 57s 🟩🟩
semgrep/ci 55s 🟩🟩
file_change_determinator 21s 🟩🟩
permission-check 11s 🟩🟩
file_change_determinator 10s 🟩
execution-performance / single-node-performance 10s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 15m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@gregnazario gregnazario enabled auto-merge (squash) December 10, 2024 21:17

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 9a89b7441e1f47ec46eb02b6c9c8e77943086cb9

two traffics test: inner traffic : committed: 14772.30 txn/s, latency: 2687.51 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5616780
two traffics test : committed: 99.92 txn/s, latency: 1402.83 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 2400 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.549, avg: 1.475", "ConsensusProposalToOrdered: max: 0.325, avg: 0.294", "ConsensusOrderedToCommit: max: 0.384, avg: 0.365", "ConsensusProposalToCommit: max: 0.674, avg: 0.659"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.06s no progress at version 34583 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.65s no progress at version 2739072 (avg 0.65s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 9a89b7441e1f47ec46eb02b6c9c8e77943086cb9

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 9a89b7441e1f47ec46eb02b6c9c8e77943086cb9 (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 16042.55 txn/s, latency: 2061.03 ms, (p50: 1700 ms, p70: 1800, p90: 2400 ms, p99: 14900 ms), latency samples: 549080
2. Upgrading first Validator to new version: 9a89b7441e1f47ec46eb02b6c9c8e77943086cb9
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7334.58 txn/s, latency: 3894.94 ms, (p50: 4400 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 137520
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7428.16 txn/s, latency: 4399.90 ms, (p50: 4700 ms, p70: 4800, p90: 4800 ms, p99: 4900 ms), latency samples: 248240
3. Upgrading rest of first batch to new version: 9a89b7441e1f47ec46eb02b6c9c8e77943086cb9
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5495.24 txn/s, latency: 5164.85 ms, (p50: 6000 ms, p70: 6100, p90: 6200 ms, p99: 6400 ms), latency samples: 111760
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5716.92 txn/s, latency: 5767.34 ms, (p50: 6200 ms, p70: 6300, p90: 6700 ms, p99: 6900 ms), latency samples: 193300
4. upgrading second batch to new version: 9a89b7441e1f47ec46eb02b6c9c8e77943086cb9
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10542.98 txn/s, latency: 2672.06 ms, (p50: 2600 ms, p70: 3100, p90: 3700 ms, p99: 3800 ms), latency samples: 187660
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11581.34 txn/s, latency: 2754.36 ms, (p50: 2700 ms, p70: 3100, p90: 3300 ms, p99: 3400 ms), latency samples: 379520
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 9a89b7441e1f47ec46eb02b6c9c8e77943086cb9 passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 9a89b7441e1f47ec46eb02b6c9c8e77943086cb9

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 9a89b7441e1f47ec46eb02b6c9c8e77943086cb9 (PR)
Upgrade the nodes to version: 9a89b7441e1f47ec46eb02b6c9c8e77943086cb9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1393.51 txn/s, submitted: 1395.76 txn/s, failed submission: 2.25 txn/s, expired: 2.25 txn/s, latency: 2186.83 ms, (p50: 2100 ms, p70: 2300, p90: 3000 ms, p99: 4300 ms), latency samples: 123800
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1333.31 txn/s, submitted: 1335.34 txn/s, failed submission: 2.03 txn/s, expired: 2.03 txn/s, latency: 2223.61 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4400 ms), latency samples: 118000
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 9a89b7441e1f47ec46eb02b6c9c8e77943086cb9 passed
Upgrade the remaining nodes to version: 9a89b7441e1f47ec46eb02b6c9c8e77943086cb9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1459.01 txn/s, submitted: 1462.67 txn/s, failed submission: 3.66 txn/s, expired: 3.66 txn/s, latency: 2092.28 ms, (p50: 2000 ms, p70: 2100, p90: 3000 ms, p99: 4200 ms), latency samples: 127440
Test Ok

@gregnazario gregnazario merged commit 7e0aaa2 into aptos-labs:main Dec 10, 2024
86 of 88 checks passed
danielxiangzl pushed a commit that referenced this pull request Dec 12, 2024
danielxiangzl pushed a commit that referenced this pull request Dec 12, 2024
georgemitenkov pushed a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants