[CLI] Direct users to dev docs for testnet faucet, improve messaging #15545
+140
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 59m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
banool
force-pushed
the
banool/cli-testnet-faucet
branch
from
3afb78b to
4533f81
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
crates/aptos/src/common/types.rs
Outdated
| return Err(CliError::CommandArgumentError("There is no faucet for mainnet. Please create and fund the account by transferring funds from another account. If you are confident you want to use a faucet, set --faucet-url or add a faucet URL to .aptos/config.yaml for the current profile".to_string())); | ||
| }, | ||
| Some(Network::Testnet) => { | ||
| return Err(CliError::CommandArgumentError("To get testnet APT you must visit https://learn.aptoslabs.com/faucet. If you are confident you want to use a faucet programatically, set --faucet-url or add a faucet URL to .aptos/config.yaml for the current profile".to_string())); |
There was a problem hiding this comment.
There is a typo in the error message - programatically should be spelled programmatically
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
banool
force-pushed
the
banool/cli-testnet-faucet
branch
3 times, most recently
from
c22d89e to
3461ad3
Compare
gregnazario
approved these changes
Dec 10, 2024
Comment on lines
+385
to
+389
| eprint!("Press [Enter] to go there now > "); | ||
| read_line("Confirmation")?; | ||
| open::that(&mint_site_url).map_err(|err| { | ||
| CliError::UnexpectedError(format!("Failed to open minting site: {}", err)) | ||
| })?; |
There was a problem hiding this comment.
hmm interesting, let's try it out and see if people don't like it
banool
changed the title
banool
force-pushed
the
banool/cli-testnet-faucet
branch
from
3461ad3 to
6087ac3
Compare
sherry-x
approved these changes
Dec 11, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are no longer running a directly accessible faucet for testnet, users must use the minting page at the dev docs: https://aptos.dev/network/faucet. This PR updates the CLI to indicate that. I also improve some of the messaging, e.g. to make it clear that for some networks, creating the account in the CLI doesn't necessarily create the account on chain.
How Has This Been Tested?
New profile on testnet:
With
--assume-yesset:New profile on devnet:
With
--faucet-urlset for devnet:New profile on mainnet:
Fund account on testnet:
With
--faucet-urlset:Fund account on devnet:
Fund account on mainnet:
Key Areas to Review
See if you can pick up any combination of args I might've missed in my testing.
Type of Change
Which Components or Systems Does This Change Impact?
Checklist