Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forge] bump graceful_overload mem threshold temporarily #15511

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

ibalajiarun
Copy link
Contributor

Description

Bumping due to #15491. Will investigate and adjust again later.

Copy link

trunk-io bot commented Dec 5, 2024

⏱️ 1h 37m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / test-target-determinator 13m 🟩🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
test-target-determinator 11m 🟩🟩
check 10m 🟩🟩
rust-doc-tests 6m 🟩
rust-cargo-deny 5m 🟩🟩🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 5m 🟩🟩🟩
check-dynamic-deps 4m 🟩🟩🟩🟩
rust-move-tests 2m
rust-doc-tests 2m
general-lints 2m 🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 44s 🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 20m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@ibalajiarun ibalajiarun requested a review from bchocho December 5, 2024 18:29
@ibalajiarun ibalajiarun enabled auto-merge (squash) December 5, 2024 18:29

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ Forge suite compat success on c2969f0b0ecd826aa1516a386aed59496a247958 ==> 3c9a913f76cafb33e670a3dce57cfa24fa834393

Compatibility test results for c2969f0b0ecd826aa1516a386aed59496a247958 ==> 3c9a913f76cafb33e670a3dce57cfa24fa834393 (PR)
1. Check liveness of validators at old version: c2969f0b0ecd826aa1516a386aed59496a247958
compatibility::simple-validator-upgrade::liveness-check : committed: 17249.55 txn/s, latency: 1966.22 ms, (p50: 2000 ms, p70: 2100, p90: 2200 ms, p99: 2400 ms), latency samples: 554040
2. Upgrading first Validator to new version: 3c9a913f76cafb33e670a3dce57cfa24fa834393
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2016.53 txn/s, submitted: 2016.70 txn/s, expired: 0.17 txn/s, latency: 3939.97 ms, (p50: 4500 ms, p70: 4700, p90: 4900 ms, p99: 5000 ms), latency samples: 130949
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7547.15 txn/s, latency: 4328.68 ms, (p50: 4600 ms, p70: 4700, p90: 4800 ms, p99: 5300 ms), latency samples: 253140
3. Upgrading rest of first batch to new version: 3c9a913f76cafb33e670a3dce57cfa24fa834393
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7488.51 txn/s, latency: 3808.35 ms, (p50: 4200 ms, p70: 4500, p90: 4500 ms, p99: 4600 ms), latency samples: 140160
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7719.56 txn/s, latency: 4243.75 ms, (p50: 4600 ms, p70: 4700, p90: 4800 ms, p99: 5300 ms), latency samples: 253020
4. upgrading second batch to new version: 3c9a913f76cafb33e670a3dce57cfa24fa834393
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11843.80 txn/s, latency: 2346.13 ms, (p50: 2600 ms, p70: 2700, p90: 2800 ms, p99: 2900 ms), latency samples: 206060
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12046.18 txn/s, latency: 2638.38 ms, (p50: 2700 ms, p70: 2800, p90: 2900 ms, p99: 3000 ms), latency samples: 393860
5. check swarm health
Compatibility test for c2969f0b0ecd826aa1516a386aed59496a247958 ==> 3c9a913f76cafb33e670a3dce57cfa24fa834393 passed
Test Ok

Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ Forge suite realistic_env_max_load success on 3c9a913f76cafb33e670a3dce57cfa24fa834393

two traffics test: inner traffic : committed: 14743.08 txn/s, latency: 2693.62 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5605700
two traffics test : committed: 99.95 txn/s, latency: 1397.15 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 1800 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.542, avg: 1.492", "ConsensusProposalToOrdered: max: 0.322, avg: 0.290", "ConsensusOrderedToCommit: max: 0.383, avg: 0.371", "ConsensusProposalToCommit: max: 0.669, avg: 0.662"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.44s no progress at version 44880 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.84s no progress at version 6316840 (avg 0.75s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ Forge suite framework_upgrade success on c2969f0b0ecd826aa1516a386aed59496a247958 ==> 3c9a913f76cafb33e670a3dce57cfa24fa834393

Compatibility test results for c2969f0b0ecd826aa1516a386aed59496a247958 ==> 3c9a913f76cafb33e670a3dce57cfa24fa834393 (PR)
Upgrade the nodes to version: 3c9a913f76cafb33e670a3dce57cfa24fa834393
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1487.45 txn/s, submitted: 1489.22 txn/s, failed submission: 1.77 txn/s, expired: 1.77 txn/s, latency: 2082.83 ms, (p50: 1800 ms, p70: 2100, p90: 3000 ms, p99: 4200 ms), latency samples: 134440
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1473.12 txn/s, submitted: 1475.72 txn/s, failed submission: 2.41 txn/s, expired: 2.61 txn/s, latency: 2012.23 ms, (p50: 2100 ms, p70: 2100, p90: 2400 ms, p99: 3600 ms), latency samples: 134442
5. check swarm health
Compatibility test for c2969f0b0ecd826aa1516a386aed59496a247958 ==> 3c9a913f76cafb33e670a3dce57cfa24fa834393 passed
Upgrade the remaining nodes to version: 3c9a913f76cafb33e670a3dce57cfa24fa834393
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1419.05 txn/s, submitted: 1422.45 txn/s, failed submission: 3.40 txn/s, expired: 3.40 txn/s, latency: 2111.83 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 3900 ms), latency samples: 125360
Test Ok

@ibalajiarun ibalajiarun merged commit 3c6e693 into main Dec 6, 2024
94 checks passed
@ibalajiarun ibalajiarun deleted the balaji/forge branch December 6, 2024 18:45
github-actions bot pushed a commit that referenced this pull request Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

💚 All backports created successfully

Status Branch Result
aptos-release-v1.25

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants