Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

untransferable test txn #15482

Merged
merged 1 commit into from
Dec 4, 2024
Merged

untransferable test txn #15482

merged 1 commit into from
Dec 4, 2024

Conversation

rtso
Copy link
Contributor

@rtso rtso commented Dec 4, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 4, 2024

⏱️ 2h 47m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
dispatch_event 18m 🟩
rust-images / rust-all 13m 🟩
execution-performance / test-target-determinator 13m 🟩🟩🟩
test-target-determinator 13m 🟩🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
check 11m 🟩🟩🟩
rust-move-tests 9m
dispatch_event 8m 🟩
rust-cargo-deny 7m 🟩🟩🟩🟩
dispatch_event 7m 🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 5m 🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 12s 21m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@rtso rtso requested a review from a team December 4, 2024 00:01
@rtso rtso marked this pull request as ready for review December 4, 2024 00:01
Copy link
Contributor Author

rtso commented Dec 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rtso rtso enabled auto-merge (rebase) December 4, 2024 00:09

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor Author

rtso commented Dec 4, 2024

Merge activity

  • Dec 4, 3:07 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@rtso rtso force-pushed the 12-03-untransferable_test_txn branch from 1944908 to 81e9126 Compare December 4, 2024 23:17

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Forge suite realistic_env_max_load success on 81e91263cdbe3b11151479a70bcb58c77d7b477a

two traffics test: inner traffic : committed: 14401.16 txn/s, latency: 2758.53 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5475600
two traffics test : committed: 100.04 txn/s, latency: 1430.60 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 2100 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.656, avg: 1.564", "ConsensusProposalToOrdered: max: 0.337, avg: 0.298", "ConsensusOrderedToCommit: max: 0.385, avg: 0.367", "ConsensusProposalToCommit: max: 0.678, avg: 0.665"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.88s no progress at version 20905 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.62s no progress at version 2727356 (avg 0.62s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Forge suite compat success on 3527aa2e299553b759c515d9843586bad48c802c ==> 81e91263cdbe3b11151479a70bcb58c77d7b477a

Compatibility test results for 3527aa2e299553b759c515d9843586bad48c802c ==> 81e91263cdbe3b11151479a70bcb58c77d7b477a (PR)
1. Check liveness of validators at old version: 3527aa2e299553b759c515d9843586bad48c802c
compatibility::simple-validator-upgrade::liveness-check : committed: 14049.95 txn/s, latency: 2143.98 ms, (p50: 1900 ms, p70: 2100, p90: 2600 ms, p99: 7900 ms), latency samples: 541200
2. Upgrading first Validator to new version: 81e91263cdbe3b11151479a70bcb58c77d7b477a
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5621.46 txn/s, latency: 5184.16 ms, (p50: 5900 ms, p70: 6100, p90: 6300 ms, p99: 6800 ms), latency samples: 105180
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6046.60 txn/s, latency: 5404.69 ms, (p50: 5900 ms, p70: 5900, p90: 6300 ms, p99: 7200 ms), latency samples: 197400
3. Upgrading rest of first batch to new version: 81e91263cdbe3b11151479a70bcb58c77d7b477a
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6829.76 txn/s, latency: 4118.52 ms, (p50: 4600 ms, p70: 4800, p90: 5000 ms, p99: 5000 ms), latency samples: 129700
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7141.41 txn/s, latency: 4601.24 ms, (p50: 4900 ms, p70: 5000, p90: 5100 ms, p99: 5500 ms), latency samples: 233860
4. upgrading second batch to new version: 81e91263cdbe3b11151479a70bcb58c77d7b477a
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11276.88 txn/s, latency: 2440.22 ms, (p50: 2500 ms, p70: 2700, p90: 3100 ms, p99: 3300 ms), latency samples: 195020
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11909.80 txn/s, latency: 2669.92 ms, (p50: 2600 ms, p70: 3000, p90: 3100 ms, p99: 3500 ms), latency samples: 386200
5. check swarm health
Compatibility test for 3527aa2e299553b759c515d9843586bad48c802c ==> 81e91263cdbe3b11151479a70bcb58c77d7b477a passed
Test Ok

@rtso rtso merged commit f60f1f0 into main Dec 4, 2024
47 checks passed
@rtso rtso deleted the 12-03-untransferable_test_txn branch December 4, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants