Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cp] Temporarily loosen backpressures, until module loading improvement speeds up blocks #15398

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

JoshLind
Copy link
Contributor

Description

This PR cherry-picks #15368 into the v1.24 branch.

Copy link

trunk-io bot commented Nov 25, 2024

⏱️ 1h 17m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-unit-tests 23m 🟩
rust-move-tests 9m 🟩
execution-performance / single-node-performance 6m 🟥
rust-unit-tests 6m
rust-move-tests 6m
test-target-determinator 6m 🟩
execution-performance / test-target-determinator 5m 🟩
rust-doc-tests 5m 🟩
check 4m 🟩
rust-cargo-deny 3m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
check-dynamic-deps 1m 🟩🟩
general-lints 54s 🟩🟩
semgrep/ci 46s 🟩🟩
file_change_determinator 24s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
test-target-determinator 6m 4m +26%

settingsfeedbackdocs ⋅ learn more about trunk.io

@JoshLind JoshLind requested a review from sherry-x November 25, 2024 21:59
@JoshLind JoshLind enabled auto-merge (rebase) November 25, 2024 22:05

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 48820c560c351ee7f9f6485d4759d046a0702bf4

two traffics test: inner traffic : committed: 13976.26 txn/s, latency: 2842.49 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3900 ms), latency samples: 5314180
two traffics test : committed: 100.02 txn/s, latency: 2059.70 ms, (p50: 1400 ms, p70: 1600, p90: 2300 ms, p99: 16500 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.161, avg: 1.426", "ConsensusProposalToOrdered: max: 0.318, avg: 0.295", "ConsensusOrderedToCommit: max: 0.383, avg: 0.373", "ConsensusProposalToCommit: max: 0.678, avg: 0.667"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.93s no progress at version 8483 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.56s no progress at version 2782738 (avg 15.56s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on c7fe4449949dccf8f7212cb03ce004f44e8f0002 ==> 48820c560c351ee7f9f6485d4759d046a0702bf4

Compatibility test results for c7fe4449949dccf8f7212cb03ce004f44e8f0002 ==> 48820c560c351ee7f9f6485d4759d046a0702bf4 (PR)
1. Check liveness of validators at old version: c7fe4449949dccf8f7212cb03ce004f44e8f0002
compatibility::simple-validator-upgrade::liveness-check : committed: 17650.60 txn/s, latency: 1903.74 ms, (p50: 1800 ms, p70: 1900, p90: 2500 ms, p99: 3900 ms), latency samples: 576160
2. Upgrading first Validator to new version: 48820c560c351ee7f9f6485d4759d046a0702bf4
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7770.93 txn/s, latency: 3569.08 ms, (p50: 3800 ms, p70: 4200, p90: 4400 ms, p99: 4600 ms), latency samples: 144460
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7711.71 txn/s, latency: 4119.62 ms, (p50: 4300 ms, p70: 4400, p90: 6000 ms, p99: 6300 ms), latency samples: 258320
3. Upgrading rest of first batch to new version: 48820c560c351ee7f9f6485d4759d046a0702bf4
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7386.47 txn/s, latency: 3871.44 ms, (p50: 4400 ms, p70: 4600, p90: 4700 ms, p99: 4800 ms), latency samples: 136440
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7413.84 txn/s, latency: 4330.17 ms, (p50: 4600 ms, p70: 4800, p90: 5600 ms, p99: 6200 ms), latency samples: 249520
4. upgrading second batch to new version: 48820c560c351ee7f9f6485d4759d046a0702bf4
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12250.21 txn/s, latency: 2280.67 ms, (p50: 2500 ms, p70: 2600, p90: 2700 ms, p99: 2900 ms), latency samples: 212800
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11676.19 txn/s, latency: 2669.08 ms, (p50: 2500 ms, p70: 2700, p90: 4500 ms, p99: 5600 ms), latency samples: 379800
5. check swarm health
Compatibility test for c7fe4449949dccf8f7212cb03ce004f44e8f0002 ==> 48820c560c351ee7f9f6485d4759d046a0702bf4 passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on c7fe4449949dccf8f7212cb03ce004f44e8f0002 ==> 48820c560c351ee7f9f6485d4759d046a0702bf4

Compatibility test results for c7fe4449949dccf8f7212cb03ce004f44e8f0002 ==> 48820c560c351ee7f9f6485d4759d046a0702bf4 (PR)
Upgrade the nodes to version: 48820c560c351ee7f9f6485d4759d046a0702bf4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1452.06 txn/s, submitted: 1454.21 txn/s, failed submission: 2.15 txn/s, expired: 2.15 txn/s, latency: 2202.03 ms, (p50: 1800 ms, p70: 2300, p90: 3700 ms, p99: 5100 ms), latency samples: 121820
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1257.97 txn/s, submitted: 1259.72 txn/s, failed submission: 1.76 txn/s, expired: 1.76 txn/s, latency: 2288.28 ms, (p50: 2100 ms, p70: 2400, p90: 3100 ms, p99: 5200 ms), latency samples: 114560
5. check swarm health
Compatibility test for c7fe4449949dccf8f7212cb03ce004f44e8f0002 ==> 48820c560c351ee7f9f6485d4759d046a0702bf4 passed
Upgrade the remaining nodes to version: 48820c560c351ee7f9f6485d4759d046a0702bf4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1405.48 txn/s, submitted: 1408.54 txn/s, failed submission: 3.05 txn/s, expired: 3.05 txn/s, latency: 2022.17 ms, (p50: 1800 ms, p70: 2100, p90: 3000 ms, p99: 4600 ms), latency samples: 128880
Test Ok

@JoshLind JoshLind merged commit f436adb into aptos-release-v1.24 Nov 25, 2024
88 of 90 checks passed
@JoshLind JoshLind deleted the cp_backpressure branch November 25, 2024 22:34
Copy link

trunk-io bot commented Nov 25, 2024

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants