Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auth header for push metrics #15069

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Oct 23, 2024

Description

this is to migrate to groundcover

How Has This Been Tested?

tried with local benchmark run

Key Areas to Review

Type of Change

  • New feature

Which Components or Systems Does This Change Impact?

  • Developer Infrastructure

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

this is to migrate to groundcover
Copy link

trunk-io bot commented Oct 23, 2024

@msmouse msmouse requested a review from a team October 23, 2024 22:53
@msmouse msmouse enabled auto-merge (squash) October 23, 2024 23:19

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 7fe3453dc9987e2cbd93f58df4653e931e56acc4

two traffics test: inner traffic : committed: 14338.96 txn/s, latency: 2766.71 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5452020
two traffics test : committed: 99.90 txn/s, latency: 1450.39 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 1700 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.978, avg: 1.552", "ConsensusProposalToOrdered: max: 0.320, avg: 0.292", "ConsensusOrderedToCommit: max: 0.388, avg: 0.377", "ConsensusProposalToCommit: max: 0.679, avg: 0.670"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.94s no progress at version 2976605 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.55s no progress at version 2976603 (avg 8.55s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7fe3453dc9987e2cbd93f58df4653e931e56acc4

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7fe3453dc9987e2cbd93f58df4653e931e56acc4 (PR)
Upgrade the nodes to version: 7fe3453dc9987e2cbd93f58df4653e931e56acc4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 965.18 txn/s, submitted: 968.07 txn/s, failed submission: 2.90 txn/s, expired: 2.90 txn/s, latency: 3302.80 ms, (p50: 2400 ms, p70: 3300, p90: 6900 ms, p99: 8400 ms), latency samples: 86680
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 981.57 txn/s, submitted: 984.34 txn/s, failed submission: 2.78 txn/s, expired: 2.78 txn/s, latency: 3129.14 ms, (p50: 2700 ms, p70: 3600, p90: 5400 ms, p99: 8400 ms), latency samples: 84860
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7fe3453dc9987e2cbd93f58df4653e931e56acc4 passed
Upgrade the remaining nodes to version: 7fe3453dc9987e2cbd93f58df4653e931e56acc4
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1139.09 txn/s, submitted: 1140.91 txn/s, failed submission: 1.81 txn/s, expired: 1.81 txn/s, latency: 2736.53 ms, (p50: 2700 ms, p70: 3000, p90: 4000 ms, p99: 6000 ms), latency samples: 100420
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7fe3453dc9987e2cbd93f58df4653e931e56acc4

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7fe3453dc9987e2cbd93f58df4653e931e56acc4 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 16927.99 txn/s, latency: 1982.14 ms, (p50: 2000 ms, p70: 2100, p90: 2300 ms, p99: 3000 ms), latency samples: 550160
2. Upgrading first Validator to new version: 7fe3453dc9987e2cbd93f58df4653e931e56acc4
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6423.97 txn/s, latency: 4389.96 ms, (p50: 5000 ms, p70: 5300, p90: 5300 ms, p99: 5400 ms), latency samples: 118940
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6425.38 txn/s, latency: 5014.49 ms, (p50: 5500 ms, p70: 5800, p90: 6300 ms, p99: 6700 ms), latency samples: 212360
3. Upgrading rest of first batch to new version: 7fe3453dc9987e2cbd93f58df4653e931e56acc4
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6461.35 txn/s, latency: 4278.99 ms, (p50: 4400 ms, p70: 5000, p90: 5800 ms, p99: 6300 ms), latency samples: 117740
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6518.55 txn/s, latency: 4896.36 ms, (p50: 5300 ms, p70: 5500, p90: 6400 ms, p99: 6700 ms), latency samples: 220560
4. upgrading second batch to new version: 7fe3453dc9987e2cbd93f58df4653e931e56acc4
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9495.37 txn/s, latency: 2997.10 ms, (p50: 3400 ms, p70: 3700, p90: 4100 ms, p99: 4400 ms), latency samples: 170820
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8053.27 txn/s, latency: 3914.47 ms, (p50: 3900 ms, p70: 4300, p90: 6100 ms, p99: 6500 ms), latency samples: 260580
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 7fe3453dc9987e2cbd93f58df4653e931e56acc4 passed
Test Ok

@msmouse msmouse merged commit 1fa915c into main Oct 24, 2024
88 checks passed
@msmouse msmouse deleted the 1023-alden-update-push-auth branch October 24, 2024 07:48
manudhundi pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants