Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CLI version to 4.2.5 #15057

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Bump CLI version to 4.2.5 #15057

merged 1 commit into from
Oct 23, 2024

Conversation

banool
Copy link
Contributor

@banool banool commented Oct 23, 2024

Description

Just a version bump to resolve a release version inconsistency issue.

How Has This Been Tested?

Just a bump for a new release.

Key Areas to Review

N/A

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@banool banool requested a review from gregnazario as a code owner October 23, 2024 12:27
Copy link

trunk-io bot commented Oct 23, 2024

⏱️ 31m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-doc-tests 5m 🟩
test-target-determinator 5m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
rust-cargo-deny 4m 🟩
check-dynamic-deps 2m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
rust-move-tests 2m 🟩
rust-move-tests 1m 🟩
general-lints 53s 🟩🟩
semgrep/ci 48s 🟩🟩
file_change_determinator 21s 🟩🟩
file_change_determinator 12s 🟩
execution-performance / single-node-performance 10s 🟩
determine-docker-build-metadata 7s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 18m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@banool banool enabled auto-merge (squash) October 23, 2024 12:29

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 4b8ab173a8d7456a7cbc57c912ac11265aea9274

two traffics test: inner traffic : committed: 13743.26 txn/s, latency: 2891.34 ms, (p50: 2700 ms, p70: 2900, p90: 3000 ms, p99: 3300 ms), latency samples: 5225480
two traffics test : committed: 100.08 txn/s, latency: 1575.04 ms, (p50: 1500 ms, p70: 1500, p90: 1600 ms, p99: 6300 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.149, avg: 1.637", "ConsensusProposalToOrdered: max: 0.329, avg: 0.302", "ConsensusOrderedToCommit: max: 0.385, avg: 0.372", "ConsensusProposalToCommit: max: 0.685, avg: 0.675"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.17s no progress at version 2669264 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.04s no progress at version 2669262 (avg 8.04s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 4b8ab173a8d7456a7cbc57c912ac11265aea9274

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 4b8ab173a8d7456a7cbc57c912ac11265aea9274 (PR)
Upgrade the nodes to version: 4b8ab173a8d7456a7cbc57c912ac11265aea9274
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1207.08 txn/s, submitted: 1209.19 txn/s, failed submission: 2.11 txn/s, expired: 2.11 txn/s, latency: 2674.47 ms, (p50: 2400 ms, p70: 3000, p90: 4200 ms, p99: 5700 ms), latency samples: 102900
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1097.59 txn/s, submitted: 1100.50 txn/s, failed submission: 2.91 txn/s, expired: 2.91 txn/s, latency: 2684.01 ms, (p50: 2400 ms, p70: 3000, p90: 4000 ms, p99: 5300 ms), latency samples: 98020
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 4b8ab173a8d7456a7cbc57c912ac11265aea9274 passed
Upgrade the remaining nodes to version: 4b8ab173a8d7456a7cbc57c912ac11265aea9274
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1160.86 txn/s, submitted: 1162.86 txn/s, failed submission: 2.00 txn/s, expired: 2.00 txn/s, latency: 2572.42 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 5700 ms), latency samples: 104700
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 4b8ab173a8d7456a7cbc57c912ac11265aea9274

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 4b8ab173a8d7456a7cbc57c912ac11265aea9274 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 13406.16 txn/s, latency: 2166.16 ms, (p50: 1600 ms, p70: 1800, p90: 2100 ms, p99: 26900 ms), latency samples: 534280
2. Upgrading first Validator to new version: 4b8ab173a8d7456a7cbc57c912ac11265aea9274
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6474.96 txn/s, latency: 4370.00 ms, (p50: 4700 ms, p70: 5300, p90: 5500 ms, p99: 5600 ms), latency samples: 122200
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6699.95 txn/s, latency: 4858.91 ms, (p50: 5300 ms, p70: 5500, p90: 5700 ms, p99: 6600 ms), latency samples: 232200
3. Upgrading rest of first batch to new version: 4b8ab173a8d7456a7cbc57c912ac11265aea9274
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6553.43 txn/s, latency: 4327.50 ms, (p50: 4800 ms, p70: 5200, p90: 5400 ms, p99: 5400 ms), latency samples: 121060
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6602.75 txn/s, latency: 4871.50 ms, (p50: 5300 ms, p70: 5500, p90: 6100 ms, p99: 6700 ms), latency samples: 225740
4. upgrading second batch to new version: 4b8ab173a8d7456a7cbc57c912ac11265aea9274
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8816.45 txn/s, latency: 3193.76 ms, (p50: 3500 ms, p70: 3800, p90: 4100 ms, p99: 4300 ms), latency samples: 155940
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8801.31 txn/s, latency: 3681.04 ms, (p50: 3600 ms, p70: 4100, p90: 4500 ms, p99: 4900 ms), latency samples: 290160
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 4b8ab173a8d7456a7cbc57c912ac11265aea9274 passed
Test Ok

@banool banool disabled auto-merge October 23, 2024 13:07
@banool banool merged commit 933b2e3 into main Oct 23, 2024
83 of 88 checks passed
@banool banool deleted the banool/cli-4.2.5 branch October 23, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants