[move] Remove legacy AsyncVM implementation

[georgemitenkov]

Description

AsyncVM is not used, and even if we decide to have it, it will be implemented differently given how MoveVM has evolved. Removing the legacy implementation so that we can iterate fast (also, it is always possible to bring it back).

How Has This Been Tested?

Key Areas to Review

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Move Compiler
• Other (specify)

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 5h 14m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	1h 57m	🟥 🟩 🟩 🟥 🟩 (+1 more)
rust-smoke-tests	30m	🟩
check	19m	🟩 🟩 🟩 🟩 🟩
execution-performance / test-target-determinator	19m	🟩 🟩 🟩 🟩 🟩
test-target-determinator	18m	🟩 🟩 🟩 🟩 🟩
rust-cargo-deny	14m	🟩 🟩 🟩 🟩 🟩 (+3 more)
check-dynamic-deps	10m	🟩 🟩 🟩 🟩 🟩 (+3 more)
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
fetch-last-released-docker-image-tag	9m	🟩 🟩 🟩 🟩 🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[georgemitenkov]

• [move] Remove legacy AsyncVM implementation #15045 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @georgemitenkov and the rest of your teammates on Graphite

[ziaptos]

We'll get back to it :)

[github-actions]

✅ Forge suite realistic_env_max_load success on c33d5f4494d47cd893c69ec2433604a87835be52

two traffics test: inner traffic : committed: 14321.99 txn/s, latency: 2771.99 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3200 ms), latency samples: 5445600
two traffics test : committed: 100.00 txn/s, latency: 1583.47 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 9300 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.990, avg: 1.548", "ConsensusProposalToOrdered: max: 0.333, avg: 0.296", "ConsensusOrderedToCommit: max: 0.375, avg: 0.364", "ConsensusProposalToCommit: max: 0.669, avg: 0.661"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.05s no progress at version 2268950 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.64s no progress at version 2268948 (avg 8.64s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> c33d5f4494d47cd893c69ec2433604a87835be52

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> c33d5f4494d47cd893c69ec2433604a87835be52 (PR)
Upgrade the nodes to version: c33d5f4494d47cd893c69ec2433604a87835be52
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1229.62 txn/s, submitted: 1230.97 txn/s, failed submission: 1.35 txn/s, expired: 1.35 txn/s, latency: 2576.94 ms, (p50: 2100 ms, p70: 2700, p90: 4500 ms, p99: 6100 ms), latency samples: 109340
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1121.74 txn/s, submitted: 1124.40 txn/s, failed submission: 2.66 txn/s, expired: 2.66 txn/s, latency: 2636.28 ms, (p50: 2100 ms, p70: 2700, p90: 4500 ms, p99: 6700 ms), latency samples: 101020
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> c33d5f4494d47cd893c69ec2433604a87835be52 passed
Upgrade the remaining nodes to version: c33d5f4494d47cd893c69ec2433604a87835be52
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1168.70 txn/s, submitted: 1170.74 txn/s, failed submission: 2.04 txn/s, expired: 2.04 txn/s, latency: 2599.41 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 6300 ms), latency samples: 103340
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> c33d5f4494d47cd893c69ec2433604a87835be52

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> c33d5f4494d47cd893c69ec2433604a87835be52 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 14412.16 txn/s, latency: 2350.49 ms, (p50: 1800 ms, p70: 1900, p90: 2700 ms, p99: 10800 ms), latency samples: 556240
2. Upgrading first Validator to new version: c33d5f4494d47cd893c69ec2433604a87835be52
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6801.25 txn/s, latency: 4226.17 ms, (p50: 4900 ms, p70: 5100, p90: 5200 ms, p99: 5300 ms), latency samples: 123040
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6211.04 txn/s, latency: 5187.74 ms, (p50: 5300 ms, p70: 5300, p90: 6900 ms, p99: 7300 ms), latency samples: 213100
3. Upgrading rest of first batch to new version: c33d5f4494d47cd893c69ec2433604a87835be52
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6954.24 txn/s, latency: 4063.77 ms, (p50: 4500 ms, p70: 5000, p90: 5100 ms, p99: 5300 ms), latency samples: 126000
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6825.57 txn/s, latency: 4720.66 ms, (p50: 5000 ms, p70: 5200, p90: 6300 ms, p99: 6800 ms), latency samples: 227020
4. upgrading second batch to new version: c33d5f4494d47cd893c69ec2433604a87835be52
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9151.33 txn/s, latency: 3055.29 ms, (p50: 3300 ms, p70: 3700, p90: 4000 ms, p99: 4600 ms), latency samples: 165440
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8486.06 txn/s, latency: 3687.56 ms, (p50: 3900 ms, p70: 4300, p90: 5600 ms, p99: 5800 ms), latency samples: 274440
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> c33d5f4494d47cd893c69ec2433604a87835be52 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking