-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure executor crate #15008
Merged
Merged
Restructure executor crate #15008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 3h 13m total CI duration on this PR
|
msmouse
force-pushed
the
1018-alden-immutable-outputs
branch
from
October 18, 2024 18:58
2c62bf0
to
f650429
Compare
msmouse
force-pushed
the
1018-alden-immutable-outputs
branch
2 times, most recently
from
October 18, 2024 21:50
22028c3
to
2a9ceed
Compare
msmouse
added
the
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
label
Oct 18, 2024
msmouse
changed the title
extract ExecutionOutput, DoGetExecutionOutput
Restructure executor crate
Oct 18, 2024
areshand
approved these changes
Oct 18, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
grao1991
approved these changes
Oct 21, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zekun000
approved these changes
Oct 21, 2024
1. put ExecutionOutput under executor-types; next is to make StateComputeResult a combination of ExecutionOutput + StateCheckpointOutput + LedgerUpdateOutput 2. leave the algorithm in the executor crate, creating DoGetExecutionOutput
msmouse
force-pushed
the
1018-alden-immutable-outputs
branch
from
October 22, 2024 00:25
2a9ceed
to
0824245
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the three stages of execution,
ExecutionOutput
,StateCheckpointOutput
,LedgerUpdateOutput
live in executor-types, and them combined will be the final StateComputeResultDoGetExecutionOutput
,DoStateCheckpoint
, andDoLedgerUpdate
live underexecutor/src/workflow
.How Has This Been Tested?
existing coverage
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?