-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use move compiler v2 by default #14967
Conversation
⏱️ 2h 34m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
5353a14
to
2dd3017
Compare
2dd3017
to
a3e74e8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -45,5 +45,6 @@ for BIN in "${BINS[@]}"; do | |||
done | |||
|
|||
# Build the Aptos Move framework and place it in dist. It can be found afterwards in the current directory. | |||
echo "MOVE_COMPILER_V2: ${MOVE_COMPILER_V2:-not set}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we dont just set this here to ensure that its set whenever we're running tools?c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make the change here instead
I originally planned to have two tools image with compiler v2 enabled/disabled so I put this in the Dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just going to keep the env var in the Dockerfile since this is already tested. This looks like the only place we use the build-tools script
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Description
Update the tools-builder image to use Move compiler v2. This will make compiler v2 the default for Forge and devnet
How Has This Been Tested?
MOVE_COMPILER_V2
env flagKey Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist