Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler V2] Turn on CFG simplification as default optimization #14923

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

fEst1ck
Copy link
Contributor

@fEst1ck fEst1ck commented Oct 10, 2024

Description

This PR enables the control flow graph simplification as a default optimization.

How Has This Been Tested?

Existing tests && comparison testing.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Copy link

trunk-io bot commented Oct 10, 2024

⏱️ 1h 14m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 38m 🟥🟥🟥🟥
rust-move-unit-coverage 11m 🟩
rust-cargo-deny 5m 🟩🟩
rust-move-tests 5m
rust-move-unit-coverage 4m 🟥
check-dynamic-deps 2m 🟩🟩🟩
dispatch_event 2m 🟥🟥
rust-move-unit-coverage 1m
rust-move-tests 1m
general-lints 1m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
dispatch_event 49s 🟥
file_change_determinator 45s 🟩🟩🟩
dispatch_event 41s 🟥
permission-check 12s 🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@fEst1ck fEst1ck enabled auto-merge (squash) October 22, 2024 18:12

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on b4e61c73b547b3a26ec0cdc3a5a319ff2d1c4a39

two traffics test: inner traffic : committed: 14077.38 txn/s, latency: 2821.49 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5352640
two traffics test : committed: 99.98 txn/s, latency: 1566.15 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 5000 ms), latency samples: 1680
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.236, avg: 0.222", "QsPosToProposal: max: 1.215, avg: 1.173", "ConsensusProposalToOrdered: max: 0.321, avg: 0.299", "ConsensusOrderedToCommit: max: 0.390, avg: 0.374", "ConsensusProposalToCommit: max: 0.690, avg: 0.672"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.38s no progress at version 39464 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.55s no progress at version 2359955 (avg 8.55s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> b4e61c73b547b3a26ec0cdc3a5a319ff2d1c4a39

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> b4e61c73b547b3a26ec0cdc3a5a319ff2d1c4a39 (PR)
Upgrade the nodes to version: b4e61c73b547b3a26ec0cdc3a5a319ff2d1c4a39
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1138.09 txn/s, submitted: 1141.52 txn/s, failed submission: 3.43 txn/s, expired: 3.43 txn/s, latency: 2641.39 ms, (p50: 2400 ms, p70: 2700, p90: 4700 ms, p99: 5700 ms), latency samples: 99660
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1182.31 txn/s, submitted: 1184.45 txn/s, failed submission: 2.13 txn/s, expired: 2.13 txn/s, latency: 2753.57 ms, (p50: 2700 ms, p70: 3000, p90: 4200 ms, p99: 6000 ms), latency samples: 99760
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> b4e61c73b547b3a26ec0cdc3a5a319ff2d1c4a39 passed
Upgrade the remaining nodes to version: b4e61c73b547b3a26ec0cdc3a5a319ff2d1c4a39
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1160.80 txn/s, submitted: 1163.27 txn/s, failed submission: 2.47 txn/s, expired: 2.47 txn/s, latency: 2598.79 ms, (p50: 2300 ms, p70: 2700, p90: 3900 ms, p99: 5600 ms), latency samples: 103540
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> b4e61c73b547b3a26ec0cdc3a5a319ff2d1c4a39

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> b4e61c73b547b3a26ec0cdc3a5a319ff2d1c4a39 (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 14772.41 txn/s, latency: 2350.94 ms, (p50: 2100 ms, p70: 2100, p90: 2300 ms, p99: 7400 ms), latency samples: 542280
2. Upgrading first Validator to new version: b4e61c73b547b3a26ec0cdc3a5a319ff2d1c4a39
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6047.53 txn/s, latency: 4438.41 ms, (p50: 5000 ms, p70: 5200, p90: 5300 ms, p99: 5500 ms), latency samples: 122580
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6623.78 txn/s, latency: 4874.81 ms, (p50: 5200 ms, p70: 5400, p90: 6400 ms, p99: 7000 ms), latency samples: 228440
3. Upgrading rest of first batch to new version: b4e61c73b547b3a26ec0cdc3a5a319ff2d1c4a39
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6827.17 txn/s, latency: 4088.09 ms, (p50: 4700 ms, p70: 5100, p90: 5200 ms, p99: 5800 ms), latency samples: 122700
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6653.57 txn/s, latency: 4778.87 ms, (p50: 5100 ms, p70: 5300, p90: 6600 ms, p99: 6700 ms), latency samples: 221060
4. upgrading second batch to new version: b4e61c73b547b3a26ec0cdc3a5a319ff2d1c4a39
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9745.02 txn/s, latency: 2793.42 ms, (p50: 2500 ms, p70: 3600, p90: 4500 ms, p99: 5200 ms), latency samples: 167800
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9544.36 txn/s, latency: 3309.71 ms, (p50: 2700 ms, p70: 4200, p90: 5400 ms, p99: 6600 ms), latency samples: 311340
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> b4e61c73b547b3a26ec0cdc3a5a319ff2d1c4a39 passed
Test Ok

@fEst1ck fEst1ck merged commit cae7cd3 into aptos-labs:main Oct 22, 2024
85 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants