Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forge] add a message to the summary on how to cancel a job #14919

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

rustielin
Copy link
Contributor

Description

Forge stable and unstable today have always() conditions on the jobs, making them impossible to cancel outside of invoking from the GH API. Add a step summary that points folks to tooling to cancel via API

@rustielin rustielin requested a review from a team as a code owner October 9, 2024 23:46
Copy link

trunk-io bot commented Oct 9, 2024

⏱️ 46m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
dispatch_event 10m 🟥
test-target-determinator 6m 🟩
check-dynamic-deps 5m 🟩🟩
execution-performance / test-target-determinator 4m 🟩
rust-cargo-deny 4m 🟩🟩
check 4m 🟩
rust-move-tests 2m 🟩
determine-test-metadata 2m 🟩
rust-move-tests 2m 🟩
determine-test-metadata 2m 🟩
fetch-last-released-docker-image-tag 1m 🟩
rust-doc-tests 1m 🟥
general-lints 54s 🟩🟩
semgrep/ci 49s 🟩🟩
file_change_determinator 26s 🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 4m 1m +205%
test-target-determinator 6m 4m +58%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@hariria hariria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it easier, maybe we can have an action we can call from aptos-core to cancel it?

@rustielin rustielin enabled auto-merge (squash) October 9, 2024 23:56

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 64a5b10d1f263d6e3ea8c0210c06c7306c03fee9

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 64a5b10d1f263d6e3ea8c0210c06c7306c03fee9 (PR)
1. Check liveness of validators at old version: 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775
compatibility::simple-validator-upgrade::liveness-check : committed: 13109.16 txn/s, latency: 2237.47 ms, (p50: 1800 ms, p70: 2000, p90: 2200 ms, p99: 21100 ms), latency samples: 516940
2. Upgrading first Validator to new version: 64a5b10d1f263d6e3ea8c0210c06c7306c03fee9
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7453.12 txn/s, latency: 3871.53 ms, (p50: 4300 ms, p70: 4500, p90: 4700 ms, p99: 4800 ms), latency samples: 141140
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6264.26 txn/s, latency: 4928.40 ms, (p50: 5100 ms, p70: 5200, p90: 6600 ms, p99: 7100 ms), latency samples: 234440
3. Upgrading rest of first batch to new version: 64a5b10d1f263d6e3ea8c0210c06c7306c03fee9
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6747.22 txn/s, latency: 4191.20 ms, (p50: 4600 ms, p70: 5000, p90: 5600 ms, p99: 5800 ms), latency samples: 128520
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7050.70 txn/s, latency: 4564.28 ms, (p50: 4800 ms, p70: 5100, p90: 6200 ms, p99: 6800 ms), latency samples: 235740
4. upgrading second batch to new version: 64a5b10d1f263d6e3ea8c0210c06c7306c03fee9
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11712.81 txn/s, latency: 2295.72 ms, (p50: 2500 ms, p70: 2600, p90: 2700 ms, p99: 2900 ms), latency samples: 204060
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9750.72 txn/s, latency: 3161.42 ms, (p50: 2700 ms, p70: 2900, p90: 6400 ms, p99: 8600 ms), latency samples: 353540
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 64a5b10d1f263d6e3ea8c0210c06c7306c03fee9 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 64a5b10d1f263d6e3ea8c0210c06c7306c03fee9

two traffics test: inner traffic : committed: 13448.24 txn/s, latency: 2959.28 ms, (p50: 2700 ms, p70: 3000, p90: 3300 ms, p99: 3600 ms), latency samples: 5113360
two traffics test : committed: 100.04 txn/s, latency: 2623.31 ms, (p50: 2600 ms, p70: 2700, p90: 2800 ms, p99: 8200 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.236, avg: 0.221", "QsPosToProposal: max: 0.293, avg: 0.252", "ConsensusProposalToOrdered: max: 0.312, avg: 0.303", "ConsensusOrderedToCommit: max: 0.480, avg: 0.460", "ConsensusProposalToCommit: max: 0.783, avg: 0.763"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.18s no progress at version 51613 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.26s no progress at version 2158520 (avg 8.26s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 64a5b10d1f263d6e3ea8c0210c06c7306c03fee9

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 64a5b10d1f263d6e3ea8c0210c06c7306c03fee9 (PR)
Upgrade the nodes to version: 64a5b10d1f263d6e3ea8c0210c06c7306c03fee9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1031.86 txn/s, submitted: 1033.18 txn/s, failed submission: 1.33 txn/s, expired: 1.33 txn/s, latency: 3173.68 ms, (p50: 2400 ms, p70: 3300, p90: 6300 ms, p99: 7600 ms), latency samples: 93360
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 950.69 txn/s, submitted: 952.57 txn/s, failed submission: 1.88 txn/s, expired: 1.88 txn/s, latency: 3258.54 ms, (p50: 2700 ms, p70: 3600, p90: 6100 ms, p99: 7900 ms), latency samples: 81020
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> 64a5b10d1f263d6e3ea8c0210c06c7306c03fee9 passed
Upgrade the remaining nodes to version: 64a5b10d1f263d6e3ea8c0210c06c7306c03fee9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 978.85 txn/s, submitted: 982.19 txn/s, failed submission: 3.33 txn/s, expired: 3.33 txn/s, latency: 3124.21 ms, (p50: 2700 ms, p70: 3300, p90: 5100 ms, p99: 7200 ms), latency samples: 88140
Test Ok

@rustielin rustielin merged commit 51894d4 into main Oct 18, 2024
104 of 108 checks passed
@rustielin rustielin deleted the rustielin/forge-cancel-message branch October 18, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants