-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[forge] add indexer_test to unstable; clean up unused forge workflows #14896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 45m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
rustielin
requested review from
yzaccc,
grao1991,
perryjrandall and
sitalkedia
October 8, 2024 21:43
sitalkedia
approved these changes
Oct 8, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
sionescu
approved these changes
Oct 9, 2024
pull_request: | ||
paths: | ||
- ".github/workflows/forge-unstable.yaml" | ||
- ".github/workflows/forge-stable.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should still be triggered by forge-unstable.yaml
.
id: hash-branch | ||
run: | | ||
# If BRANCH is empty, default to "main" | ||
if [ -z "${{ steps.determine-test-branch.outputs.BRANCH }}" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the [[
operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #14851
This PR adds the new
indexer_test
testsuite to "Forge Unstable", where it will bake for a few days, after which point we will have enough data to tune the workload and latency success criteria thresholds, and then add it to "Forge Stable". To prevent old/stale jobs from clogging up "Forge Unstable", start fresh by removing all existing jobs from there and make it run continuously at a relatively quick cadence (every 2 hrs).Also:
How Has This Been Tested?
See the dependent PR's test plan for the indexer test suite
For the GHA workflow, validation on this PR should be sufficient.
Key Areas to Review
The cleaned up workflows, and also the new cadence.
Type of Change
Which Components or Systems Does This Change Impact?
Checklist