-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get right most child #14888
Merged
Merged
Get right most child #14888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 4h 30m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
areshand
force-pushed
the
fix_get_right_most
branch
4 times, most recently
from
October 7, 2024 22:09
abff038
to
db7508e
Compare
msmouse
reviewed
Oct 7, 2024
areshand
force-pushed
the
fix_get_right_most
branch
from
October 7, 2024 23:37
db7508e
to
30fb5c6
Compare
areshand
requested review from
banool,
gregnazario and
0xmaayan
as code owners
October 7, 2024 23:37
areshand
force-pushed
the
fix_get_right_most
branch
2 times, most recently
from
October 7, 2024 23:43
417471d
to
e33a18e
Compare
areshand
force-pushed
the
fix_get_right_most
branch
from
October 8, 2024 03:46
e33a18e
to
b789423
Compare
grao1991
approved these changes
Oct 8, 2024
msmouse
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove? (we generally don't commit these)
areshand
force-pushed
the
fix_get_right_most
branch
3 times, most recently
from
October 8, 2024 18:33
024b426
to
0ca6117
Compare
areshand
force-pushed
the
fix_get_right_most
branch
from
October 8, 2024 18:48
0ca6117
to
c6b9b28
Compare
areshand
added
the
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
label
Oct 8, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
msmouse
approved these changes
Oct 8, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:run-e2e-tests
when this label is present github actions will run all land-blocking e2e tests from the PR
v1.21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When restoring sharded db is in progress, we may haven't write the root node of the sharded JMT when being interrupted.
we still want to get the rightmost child in this case to continue restoring.
How Has This Been Tested?
added unit test
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist