Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get right most child #14888

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Get right most child #14888

merged 1 commit into from
Oct 8, 2024

Conversation

areshand
Copy link
Contributor

@areshand areshand commented Oct 7, 2024

Description

When restoring sharded db is in progress, we may haven't write the root node of the sharded JMT when being interrupted.
we still want to get the rightmost child in this case to continue restoring.

How Has This Been Tested?

added unit test

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 7, 2024

⏱️ 4h 30m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 1h 9m 🟩🟩🟥
rust-cargo-deny 24m 🟩🟩🟩🟩🟩 (+11 more)
check-dynamic-deps 17m 🟩🟩🟩🟩🟩 (+11 more)
test-target-determinator 15m 🟩🟩🟩
execution-performance / test-target-determinator 14m 🟩🟩🟩
check 11m 🟩🟩🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
general-lints 7m 🟩🟩🟩🟩🟩 (+11 more)
semgrep/ci 6m 🟩🟩🟩🟩🟩 (+11 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
test-target-determinator 6m 4m +51%

settingsfeedbackdocs ⋅ learn more about trunk.io

@areshand areshand force-pushed the fix_get_right_most branch 4 times, most recently from abff038 to db7508e Compare October 7, 2024 22:09
@areshand areshand force-pushed the fix_get_right_most branch from db7508e to 30fb5c6 Compare October 7, 2024 23:37
@areshand areshand force-pushed the fix_get_right_most branch 2 times, most recently from 417471d to e33a18e Compare October 7, 2024 23:43
@areshand areshand requested a review from msmouse October 7, 2024 23:43
@areshand areshand force-pushed the fix_get_right_most branch from e33a18e to b789423 Compare October 8, 2024 03:46
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove? (we generally don't commit these)

storage/aptosdb/src/state_store/state_store_test.rs Outdated Show resolved Hide resolved
@areshand areshand force-pushed the fix_get_right_most branch 3 times, most recently from 024b426 to 0ca6117 Compare October 8, 2024 18:33
@areshand areshand force-pushed the fix_get_right_most branch from 0ca6117 to c6b9b28 Compare October 8, 2024 18:48
@areshand areshand added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Oct 8, 2024
@areshand areshand requested a review from msmouse October 8, 2024 19:51

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@areshand areshand enabled auto-merge (rebase) October 8, 2024 21:50

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

✅ Forge suite realistic_env_max_load success on c6b9b28210348ce5140cffe30afcfef29d84aefb

two traffics test: inner traffic : committed: 13305.91 txn/s, latency: 2986.68 ms, (p50: 2700 ms, p70: 3000, p90: 3300 ms, p99: 7400 ms), latency samples: 5059220
two traffics test : committed: 99.97 txn/s, latency: 2547.55 ms, (p50: 2500 ms, p70: 2600, p90: 2700 ms, p99: 8600 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.242, avg: 0.222", "QsPosToProposal: max: 0.602, avg: 0.316", "ConsensusProposalToOrdered: max: 0.331, avg: 0.307", "ConsensusOrderedToCommit: max: 0.512, avg: 0.459", "ConsensusProposalToCommit: max: 0.814, avg: 0.767"]
Max non-epoch-change gap was: 1 rounds at version 3096313 (avg 0.00) [limit 4], 1.90s no progress at version 3107876 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.14s no progress at version 1851932 (avg 7.41s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Oct 8, 2024

✅ Forge suite framework_upgrade success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> c6b9b28210348ce5140cffe30afcfef29d84aefb

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> c6b9b28210348ce5140cffe30afcfef29d84aefb (PR)
Upgrade the nodes to version: c6b9b28210348ce5140cffe30afcfef29d84aefb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1090.85 txn/s, submitted: 1092.27 txn/s, failed submission: 1.42 txn/s, expired: 1.42 txn/s, latency: 3270.57 ms, (p50: 2400 ms, p70: 3200, p90: 5400 ms, p99: 14200 ms), latency samples: 92160
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1114.75 txn/s, submitted: 1118.82 txn/s, failed submission: 4.06 txn/s, expired: 4.06 txn/s, latency: 2707.43 ms, (p50: 2400 ms, p70: 3000, p90: 4600 ms, p99: 5700 ms), latency samples: 98760
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> c6b9b28210348ce5140cffe30afcfef29d84aefb passed
Upgrade the remaining nodes to version: c6b9b28210348ce5140cffe30afcfef29d84aefb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1227.11 txn/s, submitted: 1229.34 txn/s, failed submission: 2.24 txn/s, expired: 2.24 txn/s, latency: 2600.79 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 5800 ms), latency samples: 109700
Test Ok

Copy link
Contributor

github-actions bot commented Oct 8, 2024

✅ Forge suite compat success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> c6b9b28210348ce5140cffe30afcfef29d84aefb

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> c6b9b28210348ce5140cffe30afcfef29d84aefb (PR)
1. Check liveness of validators at old version: 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775
compatibility::simple-validator-upgrade::liveness-check : committed: 12472.73 txn/s, latency: 2726.87 ms, (p50: 1800 ms, p70: 1900, p90: 3200 ms, p99: 27300 ms), latency samples: 478640
2. Upgrading first Validator to new version: c6b9b28210348ce5140cffe30afcfef29d84aefb
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7274.23 txn/s, latency: 3817.49 ms, (p50: 4000 ms, p70: 4300, p90: 5300 ms, p99: 5700 ms), latency samples: 136080
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7188.01 txn/s, latency: 4483.97 ms, (p50: 4700 ms, p70: 4900, p90: 6200 ms, p99: 6700 ms), latency samples: 242100
3. Upgrading rest of first batch to new version: c6b9b28210348ce5140cffe30afcfef29d84aefb
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7190.23 txn/s, latency: 3818.16 ms, (p50: 4200 ms, p70: 4600, p90: 4800 ms, p99: 4900 ms), latency samples: 128940
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7505.94 txn/s, latency: 4252.86 ms, (p50: 4400 ms, p70: 4800, p90: 6000 ms, p99: 6300 ms), latency samples: 250220
4. upgrading second batch to new version: c6b9b28210348ce5140cffe30afcfef29d84aefb
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 4565.41 txn/s, latency: 4488.82 ms, (p50: 2200 ms, p70: 6100, p90: 13200 ms, p99: 14800 ms), latency samples: 127220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10137.59 txn/s, latency: 3099.53 ms, (p50: 2700 ms, p70: 3000, p90: 5900 ms, p99: 7300 ms), latency samples: 355340
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> c6b9b28210348ce5140cffe30afcfef29d84aefb passed
Test Ok

@areshand areshand merged commit 5150f83 into main Oct 8, 2024
135 of 137 checks passed
@areshand areshand deleted the fix_get_right_most branch October 8, 2024 22:23
@areshand areshand added the v1.21 label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

💚 All backports created successfully

Status Branch Result
aptos-release-v1.21

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR v1.21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants