[move-coverage]: change visibility for uncovered locations #14845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 2h 28m total CI duration on this PR
|
vineethk
reviewed
Oct 2, 2024
| @@ -27,15 +27,23 @@ use std::{ | |||
| str::FromStr, | |||
| }; | |||
|
|
|||
| /// Function source coverage. | |||
There was a problem hiding this comment.
Suggested change
| /// Function source coverage. | |
| /// Source-level coverage information for a function. |
| #[derive(Clone, Debug, Serialize)] | ||
| pub struct FunctionSourceCoverage { | ||
| /// Indication for native functions. |
There was a problem hiding this comment.
Suggested change
| /// Indication for native functions. | |
| /// Is this a native function? | |
| /// If so, then `uncovered_locations` is empty. |
| pub fn_is_native: bool, | ||
|
|
||
| /// List of uncovered locations in the function. |
There was a problem hiding this comment.
Suggested change
| /// List of uncovered locations in the function. | |
| /// List of source locations in the function that were not covered. |
There was a problem hiding this comment.
I haven't looked at the code deeply, I am assuming this is what it means from looking here. Please double check.
There was a problem hiding this comment.
Yes, that's right! I'm using this in the move-mutation-test a lot these days.
Done
| #[derive(Debug, Serialize)] | ||
| pub struct SourceCoverageBuilder<'a> { | ||
| uncovered_locations: BTreeMap<Identifier, FunctionSourceCoverage>, | ||
| /// List of uncovered locations in the source code. |
There was a problem hiding this comment.
Mapping from function name to the source-level uncovered locations for that function.
| /// List of uncovered locations in the source code. | ||
| pub uncovered_locations: BTreeMap<Identifier, FunctionSourceCoverage>, | ||
|
|
||
| /// Source map. |
There was a problem hiding this comment.
Redundant comment, remove.
In the `move-mutation-test` tool, the `uncovered_locations` from `SourceCoverageBuilder` are going to be used to generate mutants for specific pieces of source code that hasn't been covered by the unit test coverage.
Rqnsom
force-pushed
the
chore/change-visibility-in-the-coverage
branch
from
2dbeacf to
9184d05
Compare
vineethk
approved these changes
Oct 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14845 +/- ##
=======================================
Coverage 59.8% 59.8%
=======================================
Files 853 853
Lines 208159 208163 +4
=======================================
+ Hits 124530 124547 +17
+ Misses 83629 83616 -13 ☔ View full report in Codecov by Sentry. |
GotenJBZ
approved these changes
Oct 3, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vineethk
added
the
CICD:run-e2e-tests
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
gwapIgot
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
move-mutation-testtool, theuncovered_locationsfromSourceCoverageBuilderare going to be used to generate mutants for specific pieces of source code that hasn't been covered by the unit test coverage.How Has This Been Tested?
N/A
Key Areas to Review
N/A
Type of Change
Which Components or Systems Does This Change Impact?
Checklist