Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aptos-cli]: update move-tool visibility #14735

Merged

Conversation

Rqnsom
Copy link
Contributor

@Rqnsom Rqnsom commented Sep 24, 2024

Ensure that the following functions are publicly visible so they can be used from the move-mutation-test tool.

  • aptos::move_tool::aptos_debug_natives::aptos_debug_natives()
  • aptos::move_tool::experiments_from_opt_level()

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Ensure that the following functions are publicly visible so they can be
used from the `move-mutation-test` tool.
- `aptos::move_tool::aptos_debug_natives::aptos_debug_natives()`
- `aptos::move_tool::experiments_from_opt_level()`
Copy link

trunk-io bot commented Sep 24, 2024

⏱️ 8h 25m total CI duration on this PR
Job Cumulative Duration Recent Runs
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 6h 2m 🟥🟥
forge-compat-test / forge 38m 🟩🟩
forge-e2e-test / forge 30m 🟩🟩
forge-framework-upgrade-test / forge 15m 🟩
execution-performance / test-target-determinator 9m 🟩🟩
test-target-determinator 8m 🟩🟩
check 7m 🟩🟩
check-dynamic-deps 6m 🟩🟩🟩
general-lints 5m 🟩🟩🟩
rust-cargo-deny 5m 🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 4m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 37s 🟩🟩🟩
file_change_determinator 21s 🟩🟩
file_change_determinator 21s 🟩🟩
execution-performance / single-node-performance 21s 🟩🟩
permission-check 11s 🟥🟥🟩🟩
permission-check 10s 🟥🟩🟩
Backport PR 9s 🟥🟥
permission-check 7s 🟥🟩🟩
determine-docker-build-metadata 7s 🟩🟩
permission-check 7s 🟥🟩🟩
permission-check 4s 🟩🟩
permission-check 4s 🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 6h 1m +23923%
execution-performance / single-node-performance 10s 18m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@vineethk vineethk self-requested a review September 24, 2024 15:06
@aluon aluon added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Sep 25, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@vineethk vineethk enabled auto-merge (squash) September 25, 2024 21:06

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on eb8b43297a1aa3735a388a77f59c6ea189d15897

two traffics test: inner traffic : committed: 13954.09 txn/s, latency: 2865.07 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 12700 ms), latency samples: 5305620
two traffics test : committed: 100.06 txn/s, latency: 1716.79 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 8700 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.235, avg: 0.220", "QsPosToProposal: max: 1.070, avg: 1.043", "ConsensusProposalToOrdered: max: 0.330, avg: 0.295", "ConsensusOrderedToCommit: max: 0.437, avg: 0.407", "ConsensusProposalToCommit: max: 0.765, avg: 0.702"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.85s no progress at version 2713849 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.84s no progress at version 2713847 (avg 8.84s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 25a081116546670e62ca927ba90478de78557056 ==> eb8b43297a1aa3735a388a77f59c6ea189d15897

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> eb8b43297a1aa3735a388a77f59c6ea189d15897 (PR)
Upgrade the nodes to version: eb8b43297a1aa3735a388a77f59c6ea189d15897
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1274.45 txn/s, submitted: 1277.39 txn/s, failed submission: 2.95 txn/s, expired: 2.95 txn/s, latency: 2415.08 ms, (p50: 2400 ms, p70: 2700, p90: 3600 ms, p99: 4600 ms), latency samples: 112440
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1227.07 txn/s, submitted: 1230.59 txn/s, failed submission: 3.52 txn/s, expired: 3.52 txn/s, latency: 2451.34 ms, (p50: 2100 ms, p70: 2400, p90: 4200 ms, p99: 6000 ms), latency samples: 111460
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> eb8b43297a1aa3735a388a77f59c6ea189d15897 passed
Upgrade the remaining nodes to version: eb8b43297a1aa3735a388a77f59c6ea189d15897
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1118.99 txn/s, submitted: 1120.09 txn/s, failed submission: 1.09 txn/s, expired: 1.09 txn/s, latency: 2657.91 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 6400 ms), latency samples: 102480
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 25a081116546670e62ca927ba90478de78557056 ==> eb8b43297a1aa3735a388a77f59c6ea189d15897

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> eb8b43297a1aa3735a388a77f59c6ea189d15897 (PR)
1. Check liveness of validators at old version: 25a081116546670e62ca927ba90478de78557056
compatibility::simple-validator-upgrade::liveness-check : committed: 13334.47 txn/s, latency: 2174.34 ms, (p50: 1800 ms, p70: 1900, p90: 2300 ms, p99: 17200 ms), latency samples: 524580
2. Upgrading first Validator to new version: eb8b43297a1aa3735a388a77f59c6ea189d15897
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7369.22 txn/s, latency: 3901.99 ms, (p50: 4300 ms, p70: 4400, p90: 4600 ms, p99: 4700 ms), latency samples: 142920
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7292.55 txn/s, latency: 4389.20 ms, (p50: 4400 ms, p70: 4600, p90: 6700 ms, p99: 6900 ms), latency samples: 244700
3. Upgrading rest of first batch to new version: eb8b43297a1aa3735a388a77f59c6ea189d15897
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7650.55 txn/s, latency: 3551.24 ms, (p50: 3500 ms, p70: 4200, p90: 4900 ms, p99: 5300 ms), latency samples: 139260
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7681.00 txn/s, latency: 4146.15 ms, (p50: 4200 ms, p70: 4400, p90: 6300 ms, p99: 6500 ms), latency samples: 258000
4. upgrading second batch to new version: eb8b43297a1aa3735a388a77f59c6ea189d15897
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12196.63 txn/s, latency: 2215.88 ms, (p50: 2400 ms, p70: 2500, p90: 2600 ms, p99: 2900 ms), latency samples: 212680
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11799.78 txn/s, latency: 2640.36 ms, (p50: 2500 ms, p70: 2700, p90: 3400 ms, p99: 5000 ms), latency samples: 381480
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> eb8b43297a1aa3735a388a77f59c6ea189d15897 passed
Test Ok

@vineethk vineethk merged commit 1d0cf10 into aptos-labs:main Sep 25, 2024
129 of 136 checks passed
@Rqnsom Rqnsom deleted the chore/make_aptos_move_too_api_public branch September 26, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants