[ts-sdk] Remove V1 SDK #14700

gregnazario · 2024-09-19T22:39:39Z

Description

SDK V1 is deprecated, we're removing the code associated, and any tests associated.

I suspect I will need to remove other pieces in CI

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

This package was deprecated on NPM. https://www.npmjs.com/package/aptos

Key Areas to Review

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-09-19T22:39:43Z

⏱️ 4h 25m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	45m	🟩 🟩
forge-compat-test / forge	42m	🟩 🟥 🟩
forge-framework-upgrade-test / forge	31m	🟩 🟩
forge-e2e-test / forge	29m	🟩 🟩
rust-cargo-deny	12m	🟩 🟩 🟥 🟩 🟩 (+1 more)
rust-move-tests	10m	🟥 🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	9m	🟩
check	7m	🟩 🟩
execution-performance / test-target-determinator	7m	🟩 🟩
test-target-determinator	7m	🟩 🟩
check-dynamic-deps	7m	🟩 🟩 🟩 🟩 🟩 (+1 more)
general-lints	5m	🟥 🟥 🟩 🟩 🟩 (+1 more)
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
rust-move-tests	3m	⬜
semgrep/ci	3m	🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check	1m	🟩 🟩 🟩 🟥 🟩 (+2 more)
file_change_determinator	1m	🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check	1m	🟩 🟩 🟩 🟥 🟩 (+2 more)
file_change_determinator	1m	🟩 🟩 🟩 🟩 🟩 (+1 more)
node-api-compatibility-tests / node-api-compatibility-tests	1m	🟩
permission-check	25s	🟩 🟩 🟩 🟩 🟩 (+1 more)
file_change_determinator	21s	🟩 🟩
permission-check	15s	🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check	8s	🟩 🟩
permission-check	7s	🟩
determine-docker-build-metadata	6s	🟩 🟩
Backport PR	4s	🟥

🚨 3 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg
forge-compat-test / forge	25m	19m
execution-performance / single-node-performance	23m	18m
general-lints	29s	2m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

0xmaayan

Huge milestone!

Might worth keeping the code for reference, but maybe rename the folder name.

For CI we should defiantly remove it

gregnazario · 2024-09-19T22:43:58Z

Huge milestone!

Might worth keeping the code for reference, but maybe rename the folder name.

For CI we should defiantly remove it

I figured, it's still in git, so let's just remove it entirely.

I can make a git tag back to the last commit with it, if that is helpful

0xmaayan · 2024-09-19T22:45:23Z

Huge milestone!
Might worth keeping the code for reference, but maybe rename the folder name.
For CI we should defiantly remove it

I figured, it's still in git, so let's just remove it entirely.

I can make a git tag back to the last commit with it, if that is helpful

Lets do it! full deprecation 🚀

github-actions · 2024-09-25T19:18:49Z

✅ Forge suite `framework_upgrade` success on `25a081116546670e62ca927ba90478de78557056` ==> `8443f4fe127956f54eceba9f3f82b992b6d82a42`

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> 8443f4fe127956f54eceba9f3f82b992b6d82a42 (PR)
Upgrade the nodes to version: 8443f4fe127956f54eceba9f3f82b992b6d82a42
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1173.21 txn/s, submitted: 1175.86 txn/s, failed submission: 2.66 txn/s, expired: 2.66 txn/s, latency: 2666.36 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 6300 ms), latency samples: 105940
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1062.41 txn/s, submitted: 1063.95 txn/s, failed submission: 1.54 txn/s, expired: 1.54 txn/s, latency: 2814.88 ms, (p50: 2400 ms, p70: 3000, p90: 4700 ms, p99: 7000 ms), latency samples: 96500
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> 8443f4fe127956f54eceba9f3f82b992b6d82a42 passed
Upgrade the remaining nodes to version: 8443f4fe127956f54eceba9f3f82b992b6d82a42
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1168.64 txn/s, submitted: 1170.59 txn/s, failed submission: 1.95 txn/s, expired: 1.95 txn/s, latency: 3143.54 ms, (p50: 2400 ms, p70: 3000, p90: 5700 ms, p99: 15400 ms), latency samples: 96100
Test Ok

github-actions · 2024-09-25T19:18:57Z

✅ Forge suite `realistic_env_max_load` success on `8443f4fe127956f54eceba9f3f82b992b6d82a42`

two traffics test: inner traffic : committed: 13824.44 txn/s, submitted: 13829.39 txn/s, expired: 4.94 txn/s, latency: 2854.03 ms, (p50: 2700 ms, p70: 3000, p90: 3000 ms, p99: 3300 ms), latency samples: 5256440
two traffics test : committed: 100.01 txn/s, latency: 1673.05 ms, (p50: 1600 ms, p70: 1700, p90: 1800 ms, p99: 3700 ms), latency samples: 1960
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.262, avg: 0.229", "QsPosToProposal: max: 1.124, avg: 1.084", "ConsensusProposalToOrdered: max: 0.323, avg: 0.302", "ConsensusOrderedToCommit: max: 0.444, avg: 0.425", "ConsensusProposalToCommit: max: 0.742, avg: 0.727"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.10s no progress at version 2121899 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.16s no progress at version 2121897 (avg 6.52s) [limit 15].
Test Ok

larry-aptos

LGTM for tests + CI part.

github-actions · 2024-09-25T20:12:15Z

✅ Forge suite `compat` success on `25a081116546670e62ca927ba90478de78557056` ==> `8443f4fe127956f54eceba9f3f82b992b6d82a42`

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> 8443f4fe127956f54eceba9f3f82b992b6d82a42 (PR)
1. Check liveness of validators at old version: 25a081116546670e62ca927ba90478de78557056
compatibility::simple-validator-upgrade::liveness-check : committed: 15019.64 txn/s, latency: 2218.75 ms, (p50: 1900 ms, p70: 2100, p90: 3800 ms, p99: 5000 ms), latency samples: 498840
2. Upgrading first Validator to new version: 8443f4fe127956f54eceba9f3f82b992b6d82a42
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5784.09 txn/s, latency: 4894.06 ms, (p50: 5300 ms, p70: 5500, p90: 6400 ms, p99: 6700 ms), latency samples: 113860
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5794.22 txn/s, latency: 5595.80 ms, (p50: 6000 ms, p70: 6200, p90: 7000 ms, p99: 7400 ms), latency samples: 198380
3. Upgrading rest of first batch to new version: 8443f4fe127956f54eceba9f3f82b992b6d82a42
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7017.83 txn/s, latency: 3897.88 ms, (p50: 4300 ms, p70: 4700, p90: 5100 ms, p99: 5400 ms), latency samples: 128840
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6987.28 txn/s, latency: 4546.18 ms, (p50: 4800 ms, p70: 5000, p90: 6400 ms, p99: 6700 ms), latency samples: 235000
4. upgrading second batch to new version: 8443f4fe127956f54eceba9f3f82b992b6d82a42
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10296.90 txn/s, latency: 2628.68 ms, (p50: 2500 ms, p70: 2900, p90: 4200 ms, p99: 4400 ms), latency samples: 176620
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10469.65 txn/s, latency: 2953.85 ms, (p50: 2500 ms, p70: 2900, p90: 5900 ms, p99: 7600 ms), latency samples: 339500
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> 8443f4fe127956f54eceba9f3f82b992b6d82a42 passed
Test Ok

gregnazario requested review from banool and 0xmaayan September 19, 2024 22:39

0xmaayan reviewed Sep 19, 2024

View reviewed changes

gregnazario requested a review from a team as a code owner September 19, 2024 22:43

0xmaayan approved these changes Sep 19, 2024

View reviewed changes

gregnazario added 3 commits September 24, 2024 13:35

[ts-sdk] Remove V1 SDK

2cf9d94

[CI] Remove TS SDK E2E tests

36875be

[api] Update readme to not refer to legacy TS SDK

1c20fb3

gregnazario force-pushed the deprecate-ts-sdk-v1 branch from 996c7d2 to 1c20fb3 Compare September 24, 2024 20:36

gregnazario added 2 commits September 24, 2024 13:42

[refactor] Remove ts-sdk more

951baeb

[refactor] Deprecate rest of SDK v1

517d7c9

gregnazario requested review from alinush, hariria and heliuchuan as code owners September 24, 2024 20:49

gregnazario enabled auto-merge (squash) September 24, 2024 22:22

This comment has been minimized.

Sign in to view

[ts-sdk] Add dummy file to ensure build continues to work

8443f4f

This comment has been minimized.

Sign in to view

larry-aptos approved these changes Sep 25, 2024

View reviewed changes

gregnazario merged commit 180bdf5 into aptos-labs:main Sep 25, 2024
45 of 46 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ts-sdk] Remove V1 SDK #14700

[ts-sdk] Remove V1 SDK #14700

gregnazario commented Sep 19, 2024 •

edited

Loading

trunk-io bot commented Sep 19, 2024 •

edited

Loading

0xmaayan left a comment

gregnazario commented Sep 19, 2024 •

edited

Loading

0xmaayan commented Sep 19, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

This comment has been minimized.

larry-aptos left a comment

github-actions bot commented Sep 25, 2024

[ts-sdk] Remove V1 SDK #14700

[ts-sdk] Remove V1 SDK #14700

Conversation

gregnazario commented Sep 19, 2024 • edited Loading

Description

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Key Areas to Review

Checklist

trunk-io bot commented Sep 19, 2024 • edited Loading

0xmaayan left a comment

Choose a reason for hiding this comment

gregnazario commented Sep 19, 2024 • edited Loading

0xmaayan commented Sep 19, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Sep 25, 2024

✅ Forge suite framework_upgrade success on 25a081116546670e62ca927ba90478de78557056 ==> 8443f4fe127956f54eceba9f3f82b992b6d82a42

github-actions bot commented Sep 25, 2024

✅ Forge suite realistic_env_max_load success on 8443f4fe127956f54eceba9f3f82b992b6d82a42

This comment has been minimized.

larry-aptos left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 25, 2024

✅ Forge suite compat success on 25a081116546670e62ca927ba90478de78557056 ==> 8443f4fe127956f54eceba9f3f82b992b6d82a42

gregnazario commented Sep 19, 2024 •

edited

Loading

trunk-io bot commented Sep 19, 2024 •

edited

Loading

gregnazario commented Sep 19, 2024 •

edited

Loading

✅ Forge suite `framework_upgrade` success on `25a081116546670e62ca927ba90478de78557056` ==> `8443f4fe127956f54eceba9f3f82b992b6d82a42`

✅ Forge suite `realistic_env_max_load` success on `8443f4fe127956f54eceba9f3f82b992b6d82a42`

✅ Forge suite `compat` success on `25a081116546670e62ca927ba90478de78557056` ==> `8443f4fe127956f54eceba9f3f82b992b6d82a42`