Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log level downgrade #14399

Merged
merged 1 commit into from
Oct 7, 2024
Merged

log level downgrade #14399

merged 1 commit into from
Oct 7, 2024

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Aug 23, 2024

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Aug 23, 2024

@zjma zjma marked this pull request as ready for review August 23, 2024 20:53
@zjma zjma enabled auto-merge (squash) August 23, 2024 20:54
Copy link
Contributor

@ibalajiarun ibalajiarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we downgrading these?

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on cf594cc3358a3185e1f2c15bf52384f545bcc9d5

two traffics test: inner traffic : committed: 11853.81 txn/s, latency: 3358.82 ms, (p50: 3100 ms, p90: 3900 ms, p99: 7800 ms), latency samples: 4507080
two traffics test : committed: 100.06 txn/s, latency: 2895.34 ms, (p50: 2600 ms, p90: 3400 ms, p99: 9200 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.268, avg: 0.226", "QsPosToProposal: max: 0.479, avg: 0.399", "ConsensusProposalToOrdered: max: 0.347, avg: 0.328", "ConsensusOrderedToCommit: max: 0.815, avg: 0.733", "ConsensusProposalToCommit: max: 1.140, avg: 1.061"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.89s no progress at version 2479358 (avg 0.23s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.04s no progress at version 2479356 (avg 8.04s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> cf594cc3358a3185e1f2c15bf52384f545bcc9d5

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> cf594cc3358a3185e1f2c15bf52384f545bcc9d5 (PR)
1. Check liveness of validators at old version: d1bf834728a0cf166d993f4728dfca54f3086fb0
compatibility::simple-validator-upgrade::liveness-check : committed: 9928.12 txn/s, latency: 3310.43 ms, (p50: 2000 ms, p90: 5000 ms, p99: 31400 ms), latency samples: 425740
2. Upgrading first Validator to new version: cf594cc3358a3185e1f2c15bf52384f545bcc9d5
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7646.09 txn/s, latency: 3708.56 ms, (p50: 4000 ms, p90: 4500 ms, p99: 4700 ms), latency samples: 141660
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7793.65 txn/s, latency: 4063.50 ms, (p50: 4100 ms, p90: 5800 ms, p99: 6400 ms), latency samples: 258640
3. Upgrading rest of first batch to new version: cf594cc3358a3185e1f2c15bf52384f545bcc9d5
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7438.29 txn/s, latency: 3763.77 ms, (p50: 4100 ms, p90: 4500 ms, p99: 4600 ms), latency samples: 141780
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7173.06 txn/s, latency: 4433.62 ms, (p50: 4300 ms, p90: 6800 ms, p99: 7000 ms), latency samples: 238020
4. upgrading second batch to new version: cf594cc3358a3185e1f2c15bf52384f545bcc9d5
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8859.22 txn/s, latency: 3147.56 ms, (p50: 2800 ms, p90: 4500 ms, p99: 5000 ms), latency samples: 159320
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7889.11 txn/s, latency: 3385.23 ms, (p50: 2800 ms, p90: 5400 ms, p99: 8500 ms), latency samples: 323600
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> cf594cc3358a3185e1f2c15bf52384f545bcc9d5 passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> cf594cc3358a3185e1f2c15bf52384f545bcc9d5

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> cf594cc3358a3185e1f2c15bf52384f545bcc9d5 (PR)
Upgrade the nodes to version: cf594cc3358a3185e1f2c15bf52384f545bcc9d5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1290.69 txn/s, submitted: 1293.39 txn/s, failed submission: 2.69 txn/s, expired: 2.69 txn/s, latency: 2551.04 ms, (p50: 2200 ms, p90: 3900 ms, p99: 5800 ms), latency samples: 115020
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1218.77 txn/s, submitted: 1222.84 txn/s, failed submission: 4.07 txn/s, expired: 4.07 txn/s, latency: 2628.98 ms, (p50: 2400 ms, p90: 4400 ms, p99: 6200 ms), latency samples: 107700
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> cf594cc3358a3185e1f2c15bf52384f545bcc9d5 passed
Upgrade the remaining nodes to version: cf594cc3358a3185e1f2c15bf52384f545bcc9d5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1088.71 txn/s, submitted: 1091.13 txn/s, failed submission: 2.42 txn/s, expired: 2.42 txn/s, latency: 3138.21 ms, (p50: 2400 ms, p90: 6500 ms, p99: 8600 ms), latency samples: 99080
Test Ok

@zjma zjma merged commit 87cbef7 into main Oct 7, 2024
79 of 88 checks passed
@zjma zjma deleted the zjma/log_level_downgrade branch October 7, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants