Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testing issues #31

Merged
merged 7 commits into from
Jul 27, 2023
Merged

fix: testing issues #31

merged 7 commits into from
Jul 27, 2023

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Jul 22, 2023

No description provided.

@Meldiron
Copy link
Contributor

Meldiron commented Jul 22, 2023

Starters template QA:

  • Node works ✅
  • PHP works ✅
  • Java works ✅
  • Kotlin works ✅
  • Ruby works ✅
  • Python Works ✅
  • Dart Works ✅
  • Swift Works ✅
  • - [x] Deno Works ✅
  • C++ Works ✅
  • .NET Works ✅
  • Rename all to just starter folders

  • In PHP, removecomposer.lock. It makes it lock to specific PHP version, but we want template to work in all of them
  • In PHP, use this to load autoload file: require(__DIR__ . '/../vendor/autoload.php');. We need to do ../ to go out of src folder, and that __DIR__ is needed for relative path to always work as expected

@loks0n loks0n changed the title chore: remove emojis fix: testing issues Jul 22, 2023
@Meldiron
Copy link
Contributor

In Dotnet, lets:

  • replace === with just ==
  • Use this syntax for response:
        return Context.Res.Json(new Dictionary<string, object?>()
        {
            { "motto", "Build Fast. Scale Big. All in One Place." },
            { "learn", "https://appwrite.io/docs" },
            { "connect", "https://appwrite.io/discord" },
            { "getInspired", "https://builtwith.appwrite.io" },
        });
  • in .csproj lets add appwrite SDK:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
...
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Appwrite" Version="0.4.2" />
  </ItemGroup>
</Project>
  • Context.Req.Send must be Context.Res.Send

@Meldiron
Copy link
Contributor

Meldiron commented Jul 26, 2023

Regarding C++:

  • Code is directly in cpp folder. we need that extra starter-template folder
  • response['motto'] -> response["motto"]. do this for all 4 variables in response object
  • Add includes at the top
#include "../RuntimeResponse.h"
#include "../RuntimeRequest.h"
#include "../RuntimeOutput.h"
#include "../RuntimeContext.h"

@Meldiron
Copy link
Contributor

In all starters, let's rename folder from starter-template to just starter

@Meldiron
Copy link
Contributor

I made all above changes while waiting for Swift to build 😅

ruby/starter/src/main.rb Outdated Show resolved Hide resolved
@loks0n
Copy link
Member Author

loks0n commented Jul 26, 2023

otherwise lgtm

@Meldiron Meldiron merged commit 7a04a67 into main Jul 27, 2023
@loks0n loks0n deleted the chore-remove-emojis branch October 3, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants