Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label method to Role helper #686

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Add label method to Role helper #686

merged 1 commit into from
Jul 11, 2023

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Jul 5, 2023

What does this PR do?

See related issue.

Test Plan

Updated tests.

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@stnguyen90 stnguyen90 force-pushed the feat-role-label branch 2 times, most recently from b5d9442 to 4b9f10c Compare July 5, 2023 23:45
@stnguyen90 stnguyen90 requested a review from lohanidamodar July 5, 2023 23:47
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I like that we are adding comments alongside as well.

@lohanidamodar lohanidamodar changed the base branch from master to 1.4.x July 11, 2023 01:10
@lohanidamodar lohanidamodar merged commit ccddb97 into 1.4.x Jul 11, 2023
@lohanidamodar lohanidamodar deleted the feat-role-label branch July 11, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants