Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chunk upload #648

Merged
merged 4 commits into from
Jul 27, 2023
Merged

fix chunk upload #648

merged 4 commits into from
Jul 27, 2023

Conversation

lohanidamodar
Copy link
Member

@lohanidamodar lohanidamodar commented Apr 19, 2023

What does this PR do?

  • The range header had some issues, fixed in appwrite in the attached PR, but will need that PR deployed for the tests to pass

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@lohanidamodar
Copy link
Member Author

⚠️ Important - This is pending merge, as it breaks the SDK for current versions of Appwrite. We would want to couple this with Appwrite 1.4.x release.

@lohanidamodar lohanidamodar changed the base branch from master to 1.4.x July 18, 2023 01:12
@lohanidamodar lohanidamodar merged commit c4ef17e into 1.4.x Jul 27, 2023
@lohanidamodar lohanidamodar deleted the fix-chunked-upload branch July 27, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants