Skip to content

fix: 🐛 Convert integer properties to int, fix model parsing #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: 🐛 Convert integer properties to int, fix model parsing #1207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a82243b
fix: 🐛 Convert integer properties to int, fix model parsing
iamngoni Oct 3, 2025
6df4bc6
fix: 🐛 Improve type handling in model template
iamngoni Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions templates/dart/lib/src/models/model.dart.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,14 @@ class {{ definition.name | caseUcfirst | overrideIdentifier }} implements Model
{%- if property.type == 'array' -%}
List.from(map['{{property.name | escapeDollarSign }}'] ?? [])
{%- else -%}
map['{{property.name | escapeDollarSign }}']
{%- if property.type == "number" -%}
{%- if not property.required %}?{% endif %}.toDouble()
{%- endif -%}
{%- if property.type == "string" -%}
{%- if not property.required %}?{% endif %}.toString()
{%- if property.type == "integer" -%}
(map['{{property.name | escapeDollarSign }}'] is int ? map['{{property.name | escapeDollarSign }}'] : {% if property.required %}int.parse(map['{{property.name | escapeDollarSign }}'].toString()){% else %}map['{{property.name | escapeDollarSign }}'] != null ? int.parse(map['{{property.name | escapeDollarSign }}'].toString()) : null{% endif %})
Comment on lines +46 to +47
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add error handling for int.parse() failures.

The integer parsing logic handles the String-to-int conversion (issue #1171) and null handling (issue #1150), but int.parse() can throw FormatException in several cases:

  1. Invalid string format: non-numeric strings like "abc" or "1.5" (decimals)
  2. Double/float values: if the server returns 1.5 (a double), toString() produces "1.5", which int.parse() rejects
  3. Required properties with null: if a required field is null, int.parse("null") throws

Consider these options:

Option 1 (recommended): Use int.tryParse() with fallback for required fields:

-                    {%- if property.type == "integer" -%}
-                        (map['{{property.name | escapeDollarSign }}'] is int ? map['{{property.name | escapeDollarSign }}'] : {% if property.required %}int.parse(map['{{property.name | escapeDollarSign }}'].toString()){% else %}map['{{property.name | escapeDollarSign }}'] != null ? int.parse(map['{{property.name | escapeDollarSign }}'].toString()) : null{% endif %})
+                    {%- if property.type == "integer" -%}
+                        (map['{{property.name | escapeDollarSign }}'] is int 
+                            ? map['{{property.name | escapeDollarSign }}'] 
+                            : {% if property.required %}(int.tryParse(map['{{property.name | escapeDollarSign }}']?.toString() ?? '') ?? 0){% else %}(map['{{property.name | escapeDollarSign }}'] != null ? int.tryParse(map['{{property.name | escapeDollarSign }}'].toString()) : null){% endif %})

Option 2: Handle doubles explicitly by truncating/rounding:

-                    {%- if property.type == "integer" -%}
-                        (map['{{property.name | escapeDollarSign }}'] is int ? map['{{property.name | escapeDollarSign }}'] : {% if property.required %}int.parse(map['{{property.name | escapeDollarSign }}'].toString()){% else %}map['{{property.name | escapeDollarSign }}'] != null ? int.parse(map['{{property.name | escapeDollarSign }}'].toString()) : null{% endif %})
+                    {%- if property.type == "integer" -%}
+                        (map['{{property.name | escapeDollarSign }}'] is int 
+                            ? map['{{property.name | escapeDollarSign }}'] 
+                            : map['{{property.name | escapeDollarSign }}'] is double
+                                ? (map['{{property.name | escapeDollarSign }}'] as double).toInt()
+                                : {% if property.required %}int.parse(map['{{property.name | escapeDollarSign }}'].toString()){% else %}(map['{{property.name | escapeDollarSign }}'] != null ? int.tryParse(map['{{property.name | escapeDollarSign }}'].toString()) : null){% endif %})
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{%- if property.type == "integer" -%}
(map['{{property.name | escapeDollarSign }}'] is int ? map['{{property.name | escapeDollarSign }}'] : {% if property.required %}int.parse(map['{{property.name | escapeDollarSign }}'].toString()){% else %}map['{{property.name | escapeDollarSign }}'] != null ? int.parse(map['{{property.name | escapeDollarSign }}'].toString()) : null{% endif %})
{%- if property.type == "integer" -%}
(map['{{property.name | escapeDollarSign }}'] is int
? map['{{property.name | escapeDollarSign }}']
: {% if property.required %}(int.tryParse(map['{{property.name | escapeDollarSign }}']?.toString() ?? '') ?? 0){% else %}(map['{{property.name | escapeDollarSign }}'] != null ? int.tryParse(map['{{property.name | escapeDollarSign }}'].toString()) : null){% endif %})
Suggested change
{%- if property.type == "integer" -%}
(map['{{property.name | escapeDollarSign }}'] is int ? map['{{property.name | escapeDollarSign }}'] : {% if property.required %}int.parse(map['{{property.name | escapeDollarSign }}'].toString()){% else %}map['{{property.name | escapeDollarSign }}'] != null ? int.parse(map['{{property.name | escapeDollarSign }}'].toString()) : null{% endif %})
{%- if property.type == "integer" -%}
(map['{{property.name | escapeDollarSign }}'] is int
? map['{{property.name | escapeDollarSign }}']
: map['{{property.name | escapeDollarSign }}'] is double
? (map['{{property.name | escapeDollarSign }}'] as double).toInt()
: {% if property.required %}int.parse(map['{{property.name | escapeDollarSign }}'].toString()){% else %}(map['{{property.name | escapeDollarSign }}'] != null ? int.tryParse(map['{{property.name | escapeDollarSign }}'].toString()) : null){% endif %})

{%- elseif property.type == "number" -%}
(map['{{property.name | escapeDollarSign }}'] is double ? map['{{property.name | escapeDollarSign }}'] : {% if property.required %}double.parse(map['{{property.name | escapeDollarSign }}'].toString()){% else %}map['{{property.name | escapeDollarSign }}'] != null ? double.parse(map['{{property.name | escapeDollarSign }}'].toString()) : null{% endif %})
{%- elseif property.type == "string" -%}
map['{{property.name | escapeDollarSign }}']{% if not property.required %}?{% endif %}.toString()
{%- else -%}
map['{{property.name | escapeDollarSign }}']
{%- endif -%}
{%- endif -%}
{%- endif -%},
Expand Down
Loading