Skip to content

fix: dotnet template issues #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

fix: dotnet template issues #1205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e736b7
fix: dotnet template issues
ChiragAgg5k Oct 1, 2025
112022a
fix: escape
ChiragAgg5k Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/SDK/Language/DotNet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,13 +478,13 @@ public function getFunctions(): array

if (isset($property['sub_schema']) && !empty($property['sub_schema'])) {
if ($property['type'] === 'array') {
$result = 'List<' . \ucfirst($property['sub_schema']) . '>';
$result = 'List<' . $this->toPascalCase($property['sub_schema']) . '>';
} else {
$result = \ucfirst($property['sub_schema']);
$result = $this->toPascalCase($property['sub_schema']);
}
} elseif (isset($property['enum']) && !empty($property['enum'])) {
$enumName = $property['enumName'] ?? $property['name'];
$result = \ucfirst($enumName);
$result = $this->toPascalCase($enumName);
} else {
$result = $this->getTypeName($property);
}
Expand All @@ -497,9 +497,9 @@ public function getFunctions(): array
}),
new TwigFunction('property_name', function (array $definition, array $property) {
$name = $property['name'];
$name = \ucfirst($name);
$name = \str_replace('$', '', $name);
if (\in_array(\strtolower($name), $this->getKeywords())) {
$name = $this->toPascalCase($name);
if (\in_array($name, $this->getKeywords())) {
$name = '@' . $name;
}
return $name;
Expand Down
5 changes: 3 additions & 2 deletions templates/dotnet/Package/Models/Model.cs.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

using System;
using System.Linq;
using System.Collections.Generic;
Expand All @@ -11,7 +12,7 @@ namespace {{ spec.title | caseUcfirst }}.Models
{
{%~ for property in definition.properties %}
[JsonPropertyName("{{ property.name }}")]
public {{ sub_schema(property) }} {{ property_name(definition, property) | overrideProperty(definition.name) }} { get; private set; }
public {{ sub_schema(property) | raw }} {{ property_name(definition, property) | overrideProperty(definition.name) }} { get; private set; }

{%~ endfor %}
{%~ if definition.additionalProperties %}
Expand All @@ -20,7 +21,7 @@ namespace {{ spec.title | caseUcfirst }}.Models
{%~ endif %}
public {{ definition.name | caseUcfirst | overrideIdentifier }}(
{%~ for property in definition.properties %}
{{ sub_schema(property) }} {{ property.name | caseCamel | escapeKeyword }}{% if not loop.last or (loop.last and definition.additionalProperties) %},{% endif %}
{{ sub_schema(property) | raw }} {{ property.name | caseCamel | escapeKeyword }}{% if not loop.last or (loop.last and definition.additionalProperties) %},{% endif %}

{%~ endfor %}
{%~ if definition.additionalProperties %}
Expand Down