fix: Concurrent Modification Error in RealtimeMixin Causing Crashes. … #205
+23
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Cleanup unused channels in RealtimeMixinc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup Unused Channels in RealtimeMixin
What does this PR do?
This pull request addresses the issue of concurrent modification errors in the RealtimeMixin class. Specifically, it modifies the _createSocket and _cleanup methods to avoid modifying collections while iterating over them. This resolves the concurrent modification errors encountered during iteration
Test Plan
I tested these changes by running the application and observing that the concurrent modification errors no longer occur. The specific test plan involved:
Related PRs and Issues
This pull request resolves the following issues:
🐛 Bug Report: RealTime subscribe throws Concurrent modification during iteration: _Map len:0 #200
🐛 Bug Report: Concurrent Modification Error in RealtimeMixin Causing Crashes #203
Have you read the Contributing Guidelines on issues?
Yes