Code overhaul #6
Conversation
SoftCreatR
commented
Sep 30, 2020
SoftCreatR
commented
- Change fully-qualified function calls to namespaced function calls for simplicity. However, the performance gain is so little, that they could be completely removed.
- Declare visibility for constants
- Add return type hints
- Perform small code optimizations
- Format files
- Add missing dependency "ext-sockets" to composer.json
- Update test namespace
- Replace Travis CI with GitHub Action
|
@SoftCreatR thanks for the PR. All changes looks great. Please keep the Travis CI file. We currently use travis for all our repos (+50) and any change to that will have to be accepted and planned for all our repos. |
|
Okay, no problem. Want me to completely remove the GitHub action, or leave it there? |
|
For now you can just remove it, thanks! |
- Changed fully-qualified function calls to namespaced function calls for simplicity. However, the performance gain is so little, that they could be completely removed. - Declared visibility for constants - Added return type hints - Performed small code optimizations - Formatted files - Added missing dependency "ext-sockets" to composer.json - Updated test namespace
|
Done ;) If you ever want to switch to GH actions, feel free to restore it: 8c2a32f |
|
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like me to send you some cool Appwrite stickers and magnets! Please note that shipping might take longer times because of COVID19. As a way of saying thank you, we have just invited you to join the Appwrite organization on GitHub. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. |
|
@SoftCreatR if you wish to contribute more on our PHP codebase, feel free to check our https://github.com/utopia-php namespace, we got lots of PHP libraries there :) |
That's already on my to-do. However, please don't forget the corresponding Docker container update, that I've pushed, too 😎 |
