Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code overhaul #5

Closed
wants to merge 1 commit into from
Closed

Code overhaul #5

wants to merge 1 commit into from

Conversation

SoftCreatR
Copy link
Contributor

  • Change fully-qualified function calls to namespaced function calls for simplicity. However, the performance gain is so little, that they could be completely removed.
  • Declare visibility for constants
  • Add return type hints
  • Perform small code optimizations
  • Re-Format files
  • Add missing dependency "ext-sockets" to composer.json
  • Update test namespace

@SoftCreatR
Code overhaul
2b0fba5 
- Changed fully-qualified function calls to namespaced function calls for simplicity. However, the performance gain is so little, that they could be completely removed.
- Declared visibility for constants
- Added return type hints
- Performed small code optimizations
- Formatted files
- Added missing dependency "ext-sockets" to composer.json
- Updated test namespace
@SoftCreatR SoftCreatR closed this Sep 25, 2020
@eldadfux
Copy link
Member

Hey @SoftCreatR, why did you close the PR? changes actually looked pretty good.

@SoftCreatR
Copy link
Contributor Author

Hey,

it's just, that I found some more optimization potential. I'll create a new PR, when done :)

@eldadfux
Copy link
Member

👌🏻

@sanitghosh sanitghosh mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoftCreatR @eldadfux