Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test enhancement #1

Merged

Conversation

peter279k
Copy link
Contributor

@peter279k peter279k commented Jul 30, 2019

Changed log

  • Add EOF for every file excluding the files in ./tests/data.
  • To let the ClamAV container initializing successfully, sleeping 60 seconds before doing next work.
  • It should let the package minimum stability is stable because it can let composer install the stable versions of dependencies.
  • Using short array syntax since the PHP version is php-5.4.
  • Using the latest version v1.0.3 for appwrite/clamav:v1.0.3.
  • According to the PHPUnit doc, the fixture methods is protected, not public.
  • The strcmp behavior is not readable, and using the trim to filter new line and compare the PONG to return bool value directly instead.
  • Using the assertTrue and assertFalse to assert the expected bool value is same as result.

@eldadfux eldadfux merged commit 1159549 into appwrite:master Jul 30, 2019
@eldadfux
Copy link
Member

Great work! Thanks for contributing to the project!

@peter279k peter279k deleted the test_enhancement branch July 30, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants