This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Add additional details for Configuring GitHub app #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
changed the title
2 tasks
2 tasks
stnguyen90
commented
Sep 9, 2023
|
This should probably be Events: docs/app/views/docs/configuration.phtml Line 162 in 63893b5 |
|
Sample experience where wrong key was used |
An example is helpful because some people were putting the SHA256 of their key instead of the actual key. It's important for the value to be in 1 line because, as of today, the upgrade only handles the .env file one line at a time.
Highlight the importance of the app name in relation to the _APP_VCS_GITHUB_APP_NAME environment variable.
It's also helpful to point out this can be anything the user wants.
Emphasize the importance of the order since an incorrect order won't work.
This is important to allow GitHub installation across multiple Appwrite projects.
It's easy to miss that there are 2 events to enable since there's only 1 row. Making the header plural can help point out there are multiple.
stnguyen90
force-pushed
the
feat-github-config
branch
from
63893b5 to
09fbb4d
Compare
gewenyu99
approved these changes
Sep 11, 2023
Separating the env vars from the table makes it look cleaner.
stnguyen90
force-pushed
the
feat-github-config
branch
from
8758d80 to
0dfda83
Compare
This was referenced Oct 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes