This repository was archived by the owner on Sep 29, 2023. It is now read-only.
Update getting-started-for-flutter.phtml #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewenyu99
suggested changes
May 23, 2023
| <h3><a href="/docs/getting-started-for-flutter#macOS" id="macOS">Mac OS</a></h3> | ||
|
|
||
| <p>For <b>Mac OS</b> add your app name and Bundle ID, You can find your Bundle Identifier in the General tab for your app's primary target in Xcode.</p> | ||
| <p>The Appwrite SDK uses ASWebAuthenticationSession on macOS 10.15+ to allow OAuth authentication. You have to change your macOS Deployment Target in Xcode to be macOS >= 10.15 to be able to build your app for macOS.</p> |
Contributor
There was a problem hiding this comment.
Do we want to use MacOS Mac OS or macOS? What's the official format? let's pick one and stick to it.
Contributor
There was a problem hiding this comment.
Okay，let's update all occurences of Mac OS and MacOS to macOS. Just so we're consistent.
stnguyen90
approved these changes
May 24, 2023
gewenyu99
approved these changes
May 24, 2023
Contributor
gewenyu99
left a comment
gewenyu99
left a comment
There was a problem hiding this comment.
I agree with all of this :D
eldadfux
approved these changes
Jun 2, 2023
This was referenced Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
YES