Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Conversation

@gewenyu99
Copy link
Contributor

@gewenyu99 gewenyu99 commented Nov 9, 2022

What does this PR do?

Amends the new REST API docs.

What's still missing?

  • List of magic strings
  • Where you can find raw OpenAPI and Swagger specs

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@gewenyu99 gewenyu99 changed the title Doc rest api REST API Docs Nov 9, 2022
@gewenyu99
Copy link
Contributor Author

gewenyu99 commented Nov 11, 2022

row-1-column-1
row-2-column-1
row-3-column-1
row-4-column-1
row-5-column-1

@gewenyu99 gewenyu99 marked this pull request as ready for review November 11, 2022 20:55
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome and much-needed! I've added my comments

@gewenyu99 gewenyu99 marked this pull request as draft November 15, 2022 20:58
@gewenyu99 gewenyu99 marked this pull request as ready for review November 21, 2022 16:26
@gewenyu99 gewenyu99 requested a review from stnguyen90 November 21, 2022 16:27
@gewenyu99 gewenyu99 marked this pull request as draft December 20, 2022 14:13
@gewenyu99 gewenyu99 marked this pull request as ready for review December 20, 2022 17:27
@gewenyu99
Copy link
Contributor Author

I also split the screenshot into many parts so it's easier to view ❤️

Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Is the syntax highlighting for HTTP working okay for you? I'm not seeing the request line highlighted, not sure if it's just me

@gewenyu99
Copy link
Contributor Author

Looking good. Is the syntax highlighting for HTTP working okay for you? I'm not seeing the request line highlighted, not sure if it's just me

Hmmmmmmmm, I think if you remove a space after the route, it highlights it differently but renders weird. I don't think the behavior is expected for prism. This is the most "normal" I can get it. Do we wanna spend some time digging into this? I'd need some help, I've no idea how the highlighting works.

@abnegate
Copy link
Member

Hmmmmmmmm, I think if you remove a space after the route, it highlights it differently but renders weird. I don't think the behavior is expected for prism. This is the most "normal" I can get it. Do we wanna spend some time digging into this? I'd need some help, I've no idea how the highlighting works.

We should definitely get it working properly, I'll try have a look later today if I get some time

(cherry picked from commit dd1bb7b)
(cherry picked from commit cf4d8ef)
(cherry picked from commit 4cb1367)
@abnegate abnegate merged commit c24c88c into feat-graphql Dec 22, 2022
@gewenyu99 gewenyu99 deleted the doc-rest-api branch January 25, 2023 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📚 Documentation: Describe how appwrite API can be invoked directly

4 participants