Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Conversation

@Akshay-Rana-Gujjar
Copy link
Contributor

What does this PR do?

Updated doc to show ISO format of timestamp in realtime payload.

Test Plan

N/A

Related PRs and Issues

appwrite/appwrite#4446

Have you read the Contributing Guidelines on issues?

Yes

@Akshay-Rana-Gujjar
Copy link
Contributor Author

@stnguyen90 @tessamero

Please check this changes and let me know if anything required from my side.

</td>
<td data-title="Description: ">
The <a href="https://en.wikipedia.org/wiki/Unix_time" rel="noopener" target="_blank">UNIX timestamp</a> from the server to ensure consistency across all client platforms and real-time technologies.
The <a href="https://en.wikipedia.org/wiki/ISO_8601" rel="noopener" target="_blank">ISO 8601</a> from the server to ensure consistency across all client platforms and real-time technologies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the description to let readers know that the timestamp is in UTC timezone for consistency :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done please check

Updated timestamp description to let user know that timestamp is in UTC timezone ISO format.
@stnguyen90 stnguyen90 requested a review from gewenyu99 October 17, 2022 23:05
Co-authored-by: Steven <[email protected]>
@stnguyen90 stnguyen90 self-requested a review October 19, 2022 15:33
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @gewenyu99?

Copy link
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as well :)

@christyjacob4 christyjacob4 merged commit ddabd12 into appwrite:main Dec 19, 2022
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants