-
Notifications
You must be signed in to change notification settings - Fork 114
updated timestamp format to ISO in realtime payload #290
updated timestamp format to ISO in realtime payload #290
Conversation
|
Please check this changes and let me know if anything required from my side. |
app/views/docs/realtime.phtml
Outdated
| </td> | ||
| <td data-title="Description: "> | ||
| The <a href="https://en.wikipedia.org/wiki/Unix_time" rel="noopener" target="_blank">UNIX timestamp</a> from the server to ensure consistency across all client platforms and real-time technologies. | ||
| The <a href="https://en.wikipedia.org/wiki/ISO_8601" rel="noopener" target="_blank">ISO 8601</a> from the server to ensure consistency across all client platforms and real-time technologies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify the description to let readers know that the timestamp is in UTC timezone for consistency :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done please check
Updated timestamp description to let user know that timestamp is in UTC timezone ISO format.
Co-authored-by: Steven <[email protected]>
stnguyen90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @gewenyu99?
gewenyu99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me as well :)
|
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |
What does this PR do?
Updated doc to show ISO format of timestamp in realtime payload.
Test Plan
N/A
Related PRs and Issues
appwrite/appwrite#4446
Have you read the Contributing Guidelines on issues?
Yes