Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

Update production guide #279

Merged
merged 10 commits into from
Jul 26, 2023
Merged

Update production guide #279

merged 10 commits into from
Jul 26, 2023

Conversation

gewenyu99
Copy link
Contributor

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

app/views/docs/production.phtml Outdated Show resolved Hide resolved
app/views/docs/production.phtml Show resolved Hide resolved
app/views/docs/production.phtml Outdated Show resolved Hide resolved
app/views/docs/production.phtml Outdated Show resolved Hide resolved
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my review.

@gewenyu99
Copy link
Contributor Author

Thanks for the comments @Meldiron and @stnguyen90

I think the installation docs really does need a good touchup, esp. cause we want to keep our self-hosted service well supported :)

@gewenyu99 gewenyu99 marked this pull request as ready for review November 11, 2022 21:37
@gewenyu99
Copy link
Contributor Author

gewenyu99-legendary-fishstick-77j4rw47w7gf94x-2080 preview app github dev_docs_production

@gewenyu99 gewenyu99 changed the title Update production guide to conform to guidelines proposed in PR #229 Update production guide Jun 15, 2023
app/views/docs/production.phtml Outdated Show resolved Hide resolved
app/views/docs/production.phtml Outdated Show resolved Hide resolved
app/views/docs/production.phtml Show resolved Hide resolved
app/views/docs/production.phtml Outdated Show resolved Hide resolved
@gewenyu99
Copy link
Contributor Author

gewenyu99 commented Jul 10, 2023

localhost_2080_docs_production (1)

@gewenyu99 gewenyu99 requested a review from eldadfux July 10, 2023 19:11
@eldadfux eldadfux dismissed Meldiron’s stale review July 26, 2023 00:01

Addressed comments.

@eldadfux eldadfux merged commit 5258dae into main Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants