Fix-248-Copy-button-issue #565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
stnguyen90
requested changes
Oct 5, 2023
| @@ -24,7 +24,7 @@ | |||
| }; | |||
| </script> | |||
|
|
|||
| <div> | |||
| <div id="tooltip-container"> | |||
There was a problem hiding this comment.
It's best to avoid IDs when possible since they're highly selective regarding CSS, and IDs should be unique, but this component can be used multiple times/places. For example,
| @@ -37,7 +37,8 @@ | |||
| on:mouseenter={() => setTimeout(() => (content = 'Click to copy'))} | |||
| use:tooltip={{ | |||
| content, | |||
| hideOnClick: false | |||
| hideOnClick: false, | |||
| appendTo: document.getElementById('tooltip-container') | |||
There was a problem hiding this comment.
Nice find! I do think this is on the right track. Looking at the documentation, appendTo can be a function that takes a reference to the element itself, so we can change this to:
Suggested change
| appendTo: document.getElementById('tooltip-container') | |
| appendTo: (ref) => ref.parentElement.parentElement |
Be sure to add a comment or commit message to explain why we need to do ref.parentElement.parentElement..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Shows Copy pop while hovering on the copy button and shows 'copied' when button is clicked
Test Plan
Tested locally
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
(Write your answer here.)