Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Runtime versions in templates #546

Merged
merged 17 commits into from
Sep 15, 2023
Merged

Conversation

Meldiron
Copy link
Contributor

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 7:03pm
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 7:03pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 7:03pm

@stnguyen90
Copy link
Contributor

Made this change on purpose, as I don't image you typically search by runtime version rather than runtime, where do you think versions should be included?

@loks0n, we need Design involved and whatever we decide, it should be consistent between the list and details pages.

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality working fine. i was able to create a new function using git with a different node runtime version than previously on 1.4.2.

image

@TorstenDittmann TorstenDittmann merged commit 1d604a0 into main Sep 15, 2023
2 checks passed
@TorstenDittmann TorstenDittmann deleted the fix-template-runtime-versions branch September 15, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants