Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 1.4 QA fixes after release #530

Merged
merged 25 commits into from
Sep 6, 2023
Merged

fix: 1.4 QA fixes after release #530

merged 25 commits into from
Sep 6, 2023

Conversation

ArmanNik
Copy link
Member

@ArmanNik ArmanNik commented Sep 5, 2023

What does this PR do?

Various fixes from QA

Test Plan

Manual

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Sep 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 9:40am
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 9:40am
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 9:40am

@ArmanNik ArmanNik changed the title Fix 1.4 qa after release fix: 1.4 QA fixes after release Sep 5, 2023
@ArmanNik ArmanNik marked this pull request as draft September 5, 2023 14:17
@ArmanNik ArmanNik self-assigned this Sep 5, 2023
@ArmanNik ArmanNik marked this pull request as ready for review September 5, 2023 17:29
christyjacob4
christyjacob4 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please address the comments

@TorstenDittmann TorstenDittmann merged commit 20b28e5 into main Sep 6, 2023
@TorstenDittmann TorstenDittmann deleted the fix-1.4-QA-after-release branch September 6, 2023 10:52
This was referenced Oct 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees

@ArmanNik ArmanNik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArmanNik @TorstenDittmann @christyjacob4