Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear validator when closing wizard #483

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Jul 26, 2023

What does this PR do?

Clear wizard interceptor on wizard start and close. Without doing this, an interceptor from a different wizard can run when a new wizard is opened causing incorrect validation.

Fixes appwrite#4847

Test Plan

  1. Open Add a web platform wizard
  2. Cancel
  3. Open API key wizard
  4. Fill out name
  5. Submit

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

Without doing this, an interceptor from a different wizard can run
when a new wizard is opened causing incorrect validation.
@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 11:22pm
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 11:22pm
console-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 11:22pm

Before this, we kept getting warnings like:

  Type 'typeof Wizard__SvelteComponent_' is missing the
  following properties from type 'SvelteComponentDev'
@TorstenDittmann TorstenDittmann merged commit 39429c6 into main Jul 27, 2023
@TorstenDittmann TorstenDittmann deleted the fix-4847-fix-wizard-reset branch July 27, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Create an API Key: Param "name" is not optional
2 participants