-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show user's last activity #475
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@stnguyen90 we should omit the time, the user update method happens only once a day and we record the time of the first activity of the day, starting with the 2nd activity the time is out of sync and misleading. The next update will only happen the next day. |
@eldadfux, that's a good idea to reduce confusion. FYI, we still might have some confusing data due to timezones. |
Why can't we take care of timezone on the console side? we should have the information on the timestamp returned from the API. Also, do we explain in the API docs that this timestamp updates once a day? Anyway, I strongly believe we need to omit the time, the first question we'll get on Discord is why the user activity isn't updating when they see the time is stuck throughout the day. BTW, we also have the same issue with API key, we need to fix both. |
Let's say there's been recent activity, but the timestamp is today at
Here's a PR: appwrite/appwrite#5855. |
7bff1a3
to
f99d7bf
Compare
This is fine for me, the goal here was just to show a rough range of your activity. We didn't plan for it to be accurate to the minute. We need to do the same for the API key |
f99d7bf
to
7bb1a12
Compare
@eldadfux, I updated it for API keys too. |
Since accessedAt is only updated once in the last 24 hours, showing the time can cause confusion.
7bb1a12
to
28b4b99
Compare
What does this PR do?
Show users' last activity on users list and detail pages.
Test Plan
Manual:
User Last Accessed
API Key Last Accessed
Related PRs and Issues
Depends on new Console SDK release and
Have you read the Contributing Guidelines on issues?
Yes