Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: accessible tab kbd navigation #437

Merged
merged 4 commits into from
Jul 11, 2023
Merged

feat: accessible tab kbd navigation #437

merged 4 commits into from
Jul 11, 2023

Conversation

TGlide
Copy link
Contributor

@TGlide TGlide commented May 10, 2023

What does this PR do?

Adds accessible tab controls, following the ARIA APG: https://www.w3.org/WAI/ARIA/apg/

Test Plan

Manual

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes

@TGlide TGlide added the enhancement New feature or request label May 10, 2023
@TGlide TGlide self-assigned this May 10, 2023
@vercel
Copy link

vercel bot commented May 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 11:42am
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 11:42am

ArmanNik
ArmanNik reviewed May 30, 2023
View reviewed changes
Copy link
Member

@ArmanNik ArmanNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future improvement suggestion:

When a tab is selected, and navigation is triggered, the tabs lose focus after the page loads.
It would be nice to keep the focus on the tab after navigation 🤔

src/lib/components/tab.svelte Outdated Show resolved Hide resolved
src/lib/components/tab.svelte Outdated Show resolved Hide resolved
ArmanNik
ArmanNik reviewed May 30, 2023
View reviewed changes
Copy link
Member

@ArmanNik ArmanNik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future improvement suggestion (might not be easily doable):

When a tab is selected, and navigation is triggered, the tabs lose focus after the page loads.
It would be nice to keep the focus on the tab after navigation 🤔

TorstenDittmann
TorstenDittmann reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think once @ArmanNik comments has been resolved we can merge it :)

@TGlide
Copy link
Contributor Author

TGlide commented May 31, 2023

Future improvement suggestion (might not be easily doable):

When a tab is selected, and navigation is triggered, the tabs lose focus after the page loads. It would be nice to keep the focus on the tab after navigation 🤔

Nice idea!

@TGlide
Copy link
Contributor Author

TGlide commented May 31, 2023

@TorstenDittmann @ArmanNik done 😉

@TorstenDittmann
Copy link
Contributor

@TorstenDittmann @ArmanNik done 😉

tests are failing 👍🏻

@TGlide
Copy link
Contributor Author

TGlide commented Jul 3, 2023

@TorstenDittmann @ArmanNik done 😉

tests are failing 👍🏻

Fixed!

@TorstenDittmann TorstenDittmann merged commit 33432d2 into main Jul 11, 2023
@TorstenDittmann TorstenDittmann deleted the feat/accessible-tabs branch July 11, 2023 14:39
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

@ArmanNik ArmanNik Awaiting requested review from ArmanNik

Assignees

@TGlide TGlide

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TGlide @TorstenDittmann @ArmanNik