Fix 5204 Use standard syntax for web code sample when loading the appwrite script #336
Conversation
|
@spontaneouscombustion is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
|
@spontaneouscombustion This PR right now is breaking the build and probably can't be merged as it as. Please, check this and try to fix it. |
|
sorry. i am not familiar with svelte. I just noticed about the script end tag on the same file. that maybe the cause of this build issue. added commit to fix it. |
|
LGTM! |
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| const example1 = `import { Client } from 'appwrite';`; | |||
| const example2 = | |||
| `<script src="https://cdn.jsdelivr.net/npm/appwrite@${$versions['client-web']}" /> | |||
| `<script src="https://cdn.jsdelivr.net/npm/appwrite@${$versions['client-web']}"></script` + `>` | |||
There was a problem hiding this comment.
There's a problem that's causing a build error. Please make sure the console builds successfully.
|
removed excess backtick. |
|
@spontaneouscombustion looks good, can you run the formatter and we can merge then 👍🏻 |
|
@spontaneouscombustion Follow along this and the issue will be fixed and will be ready to merge. |
You can just run |
…b-code-sample-when-loading-the-script
|
@spontaneouscombustion please run |
|
Closing due to inactivity. |
What does this PR do?
fixes the sample web code to use the standard syntax instead of self-closing syntax when loading the appwrite script
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
appwrite/appwrite#5204
Have you read the Contributing Guidelines on issues?
Yes