Skip to content

fix: adjust max storage conversion and row security change #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarshMN2345 merged 3 commits into from
Feb 9, 2026
Merged

fix: adjust max storage conversion and row security change #2842

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f09baa8
fix for conversion
HarshMN2345 Feb 7, 2026
4490c79
fix: for row security also changing
HarshMN2345 Feb 7, 2026
c773fd0
fix f=gigabytes
HarshMN2345 Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/helpers/unit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export function createValueUnitPair<T = string>(initialValue = 0, units: Unit<T>
}

const unitInBase = v * prevUnit.value;
return unitInBase / newUnit.value;
return Math.round(unitInBase / newUnit.value);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
});
});
return {
Expand Down
5 changes: 4 additions & 1 deletion ...ject-[region]-[project]/databases/database-[database]/table-[table]/settings/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@
return {
name: table.name,
tableId: page.params.table,
databaseId: page.params.database
databaseId: page.params.database,
rowSecurity: table.recordSecurity,
enabled: table.enabled,
permissions: table.$permissions
};
});

Expand Down
6 changes: 2 additions & 4 deletions ...ole)/project-[region]-[project]/storage/bucket-[bucket]/settings/updateMaxFileSize.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@
const options = units.map((v) => ({ label: v.name, value: v.name }));
$: selectedUnit = $unit;

const maxValue = function formMaxFileSize() {
return (service * 1000 * 1000) / units.find((unit) => unit.name === selectedUnit).value;
};
$: maxValue = (service * 1000 * 1000) / units.find((unit) => unit.name === selectedUnit).value;

function updateMaxSize() {
updateBucket(
Expand Down Expand Up @@ -80,7 +78,7 @@
disabled={$readOnly && !GRACE_PERIOD_OVERRIDE}
placeholder={bucket.maximumFileSize.toString()}
min={0}
max={isCloud ? maxValue() : Infinity}
max={isCloud ? maxValue : Infinity}
bind:value={$value} />
<InputSelect required id="bytes" label="Bytes" {options} bind:value={$unit} />
</svelte:fragment>
Expand Down
Loading