Fix create variable modal not resetting in function wizard #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stnguyen90
requested review from
ArmanNik and
TorstenDittmann
and removed request for
ArmanNik
2 tasks
ArmanNik
reviewed
Nov 22, 2022
| @@ -16,13 +16,18 @@ | |||
|
|
|||
| const dispatch = createEventDispatcher(); | |||
|
|
|||
| const close = () => { | |||
There was a problem hiding this comment.
Small thing: I think we are trying to use regular functions instead of arrow functions. The rest lgtm 👍
stnguyen90
force-pushed
the
fix-4743-create-variable-wizard
branch
from
dd55834 to
ccf8df0
Compare
ArmanNik
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensure
selectedVaris reset after updating a variable so that the Create Variable modal is functionalTest Plan
Manual
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes